mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-13 02:45:35 +00:00
Code Issues 1 Projects Releases Wiki Activity

videodecoder: plug leak when frames are released on subclass stop

Browse source 
They end up stored in the 'pending_events' list and should be
freed after calling stop
This commit is contained in:
Thiago Santos 2014-01-17 10:17:29 -03:00
parent 2aa26a9807
commit 47f720a8f0
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
gst-libs/gst/video/gstvideodecoder.c
View file

@ -2156,13 +2156,30 @@ gst_video_decoder_change_state (GstElement * element, GstStateChange transition)
ret = GST_ELEMENT_CLASS (parent_class)->change_state (element, transition);
switch (transition) {
case GST_STATE_CHANGE_PAUSED_TO_READY:
case GST_STATE_CHANGE_PAUSED_TO_READY:{
gboolean stopped = TRUE;
GST_VIDEO_DECODER_STREAM_LOCK (decoder);
gst_video_decoder_reset (decoder, TRUE, TRUE);
GST_VIDEO_DECODER_STREAM_UNLOCK (decoder);
if (decoder_class->stop && !decoder_class->stop (decoder))
if (decoder_class->stop) {
stopped = decoder_class->stop (decoder);
/* the subclass might have released frames and events from freed frames
* are stored in the pending_events list */
GST_VIDEO_DECODER_STREAM_LOCK (decoder);
g_list_free_full (decoder->priv->pending_events, (GDestroyNotify)
gst_event_unref);
decoder->priv->pending_events = NULL;
GST_VIDEO_DECODER_STREAM_UNLOCK (decoder);
}
if (!stopped)
goto stop_failed;
break;
}
case GST_STATE_CHANGE_READY_TO_NULL:
/* close device/library if needed */
if (decoder_class->close && !decoder_class->close (decoder))