mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-30 12:49:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests/check/elements/videotestsrc.c: Returning a return value often helps. In this case, we don't need the return val...

Browse source 
Original commit message from CVS:
* tests/check/elements/videotestsrc.c: (check_rgb_buf):
Returning a return value often helps. In this case, we
don't need the return value anyway, so just get rid of it.
Should make build bots much happier.
This commit is contained in:
Tim-Philipp Müller 2006-09-02 13:20:59 +00:00
parent c063f05389
commit c5d63b1c52
2 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,10 @@
2006-09-02 Tim-Philipp Müller <tim at centricular dot net>
* tests/check/elements/videotestsrc.c: (check_rgb_buf):
Returning a return value often helps. In this case, we
don't need the return value anyway, so just get rid of it.
Should make build bots much happier.
2006-09-02 Tim-Philipp Müller <tim at centricular dot net>
* gst/videotestsrc/videotestsrc.c: (paintinfo_find_by_structure),
@ -12,7 +19,7 @@
* tests/check/elements/videotestsrc.c: (right_shift_colour),
(fix_expected_colour), (check_rgb_buf), (got_buf_cb),
(GST_START_TEST), (videotestsrc_suite):
(check_rgb_buf), (videotestsrc_suite):
Add unit tests for videotestsrc's RGB output.
2006-09-01 Tim-Philipp Müller <tim at centricular dot net>

13
tests/check/elements/videotestsrc.c
View file

@ -155,7 +155,7 @@ fix_expected_colour (guint32 col_mask, guint8 col_expected)
return col_expected & mask;
}
static gboolean
static void
check_rgb_buf (const guint8 * pixels, guint32 r_mask, guint32 g_mask,
guint32 b_mask, guint32 a_mask, guint8 r_expected, guint8 g_expected,
guint8 b_expected, guint endianness, guint bpp, guint depth)
@ -378,12 +378,11 @@ GST_START_TEST (test_rgb_formats)
/* now check the first pixel */
fail_unless (check_rgb_buf (GST_BUFFER_DATA (buf),
rgb_formats[i].red_mask, rgb_formats[i].green_mask,
rgb_formats[i].blue_mask, rgb_formats[i].alpha_mask,
test_patterns[p].r_expected, test_patterns[p].g_expected,
test_patterns[p].b_expected, endianness, rgb_formats[i].bpp,
rgb_formats[i].depth));
check_rgb_buf (GST_BUFFER_DATA (buf), rgb_formats[i].red_mask,
rgb_formats[i].green_mask, rgb_formats[i].blue_mask,
rgb_formats[i].alpha_mask, test_patterns[p].r_expected,
test_patterns[p].g_expected, test_patterns[p].b_expected,
endianness, rgb_formats[i].bpp, rgb_formats[i].depth);
gst_buffer_unref (buf);
buf = NULL;