diff --git a/ChangeLog b/ChangeLog index 0dc5911128..272875687a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2006-09-02 Tim-Philipp Müller + + * tests/check/elements/videotestsrc.c: (check_rgb_buf): + Returning a return value often helps. In this case, we + don't need the return value anyway, so just get rid of it. + Should make build bots much happier. + 2006-09-02 Tim-Philipp Müller * gst/videotestsrc/videotestsrc.c: (paintinfo_find_by_structure), @@ -12,7 +19,7 @@ * tests/check/elements/videotestsrc.c: (right_shift_colour), (fix_expected_colour), (check_rgb_buf), (got_buf_cb), - (GST_START_TEST), (videotestsrc_suite): + (check_rgb_buf), (videotestsrc_suite): Add unit tests for videotestsrc's RGB output. 2006-09-01 Tim-Philipp Müller diff --git a/tests/check/elements/videotestsrc.c b/tests/check/elements/videotestsrc.c index 1378a10fc6..7a08c24df7 100644 --- a/tests/check/elements/videotestsrc.c +++ b/tests/check/elements/videotestsrc.c @@ -155,7 +155,7 @@ fix_expected_colour (guint32 col_mask, guint8 col_expected) return col_expected & mask; } -static gboolean +static void check_rgb_buf (const guint8 * pixels, guint32 r_mask, guint32 g_mask, guint32 b_mask, guint32 a_mask, guint8 r_expected, guint8 g_expected, guint8 b_expected, guint endianness, guint bpp, guint depth) @@ -378,12 +378,11 @@ GST_START_TEST (test_rgb_formats) /* now check the first pixel */ - fail_unless (check_rgb_buf (GST_BUFFER_DATA (buf), - rgb_formats[i].red_mask, rgb_formats[i].green_mask, - rgb_formats[i].blue_mask, rgb_formats[i].alpha_mask, - test_patterns[p].r_expected, test_patterns[p].g_expected, - test_patterns[p].b_expected, endianness, rgb_formats[i].bpp, - rgb_formats[i].depth)); + check_rgb_buf (GST_BUFFER_DATA (buf), rgb_formats[i].red_mask, + rgb_formats[i].green_mask, rgb_formats[i].blue_mask, + rgb_formats[i].alpha_mask, test_patterns[p].r_expected, + test_patterns[p].g_expected, test_patterns[p].b_expected, + endianness, rgb_formats[i].bpp, rgb_formats[i].depth); gst_buffer_unref (buf); buf = NULL;