mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

dvbsrc: add fixme note on DTV_LNA setting

Browse source 
Rephrase another comment while at it
This commit is contained in:
Reynaldo H. Verdejo Pinochet 2014-10-24 19:12:33 -03:00
parent ed7e763b9d
commit c1d48d4acd
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sys/dvb/gstdvbsrc.c
View file

@ -2316,8 +2316,8 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props)
/** /**
* We are not dropping out but issuing a warning in case of wrong * We are not dropping out but issuing a warning in case of wrong
* parameter combinations as this behavior should be mandated by the * parameter combinations as failover behavior should be mandated
* driver. Worst case scenario it will just fail at tuning. * by the driver. Worst case scenario it will just fail at tuning.
*/ */
switch (object->delsys) { switch (object->delsys) {
@ -2508,6 +2508,10 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props)
set_prop (props->props, &n, DTV_GUARD_INTERVAL, object->guard_interval); set_prop (props->props, &n, DTV_GUARD_INTERVAL, object->guard_interval);
set_prop (props->props, &n, DTV_INTERLEAVING, object->interleaving); set_prop (props->props, &n, DTV_INTERLEAVING, object->interleaving);
/* FIXME: Make the LNA on/off switch a property and proxy on dvbbasebin */ /* FIXME: Make the LNA on/off switch a property and proxy on dvbbasebin */
/* FIXME: According to v4l advice (see libdvbv5 implementation) this
* property should be set separately as not all drivers will ignore it
* if unsupported. An alternative would be to get the dvb API contract
* revised on this regard */
set_prop (props->props, &n, DTV_LNA, LNA_AUTO); set_prop (props->props, &n, DTV_LNA, LNA_AUTO);
GST_INFO_OBJECT (object, "Tuning DTMB to %d Hz", freq); GST_INFO_OBJECT (object, "Tuning DTMB to %d Hz", freq);
break; break;