From c1d48d4acdd4e261d2813c41f9aee2bc48943bd7 Mon Sep 17 00:00:00 2001 From: "Reynaldo H. Verdejo Pinochet" Date: Fri, 24 Oct 2014 19:12:33 -0300 Subject: [PATCH] dvbsrc: add fixme note on DTV_LNA setting Rephrase another comment while at it --- sys/dvb/gstdvbsrc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/dvb/gstdvbsrc.c b/sys/dvb/gstdvbsrc.c index 49f3e51d8a..293e3d66a8 100644 --- a/sys/dvb/gstdvbsrc.c +++ b/sys/dvb/gstdvbsrc.c @@ -2316,8 +2316,8 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props) /** * We are not dropping out but issuing a warning in case of wrong - * parameter combinations as this behavior should be mandated by the - * driver. Worst case scenario it will just fail at tuning. + * parameter combinations as failover behavior should be mandated + * by the driver. Worst case scenario it will just fail at tuning. */ switch (object->delsys) { @@ -2508,6 +2508,10 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props) set_prop (props->props, &n, DTV_GUARD_INTERVAL, object->guard_interval); set_prop (props->props, &n, DTV_INTERLEAVING, object->interleaving); /* FIXME: Make the LNA on/off switch a property and proxy on dvbbasebin */ + /* FIXME: According to v4l advice (see libdvbv5 implementation) this + * property should be set separately as not all drivers will ignore it + * if unsupported. An alternative would be to get the dvb API contract + * revised on this regard */ set_prop (props->props, &n, DTV_LNA, LNA_AUTO); GST_INFO_OBJECT (object, "Tuning DTMB to %d Hz", freq); break;