mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 04:01:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtpsource: rewrite timeout-check to avoid underflow

Browse source 
If current_time is < collision_timeout, we get an uint64 underflow, and
the check will trigger prematurely.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/817>
This commit is contained in:
Havard Graff 2020-11-13 12:39:53 +01:00
parent 5a2f9d510f
commit 97ced29277
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/rtpmanager/rtpsource.c
View file

@ -1831,7 +1831,7 @@ timeout_conflicting_addresses (GList * conflicting_addresses,
RTPConflictingAddress *known_conflict = item->data; RTPConflictingAddress *known_conflict = item->data;
GList *next_item = g_list_next (item); GList *next_item = g_list_next (item);
if (known_conflict->time < current_time - collision_timeout) { if (known_conflict->time + collision_timeout < current_time) {
gchar *buf; gchar *buf;
conflicting_addresses = g_list_delete_link (conflicting_addresses, item); conflicting_addresses = g_list_delete_link (conflicting_addresses, item);