From 97ced29277500b631c13dc71a0a7bbc5fdb1c784 Mon Sep 17 00:00:00 2001 From: Havard Graff Date: Fri, 13 Nov 2020 12:39:53 +0100 Subject: [PATCH] rtpsource: rewrite timeout-check to avoid underflow If current_time is < collision_timeout, we get an uint64 underflow, and the check will trigger prematurely. Part-of: --- gst/rtpmanager/rtpsource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst/rtpmanager/rtpsource.c b/gst/rtpmanager/rtpsource.c index 628005e5bb..865848c495 100644 --- a/gst/rtpmanager/rtpsource.c +++ b/gst/rtpmanager/rtpsource.c @@ -1831,7 +1831,7 @@ timeout_conflicting_addresses (GList * conflicting_addresses, RTPConflictingAddress *known_conflict = item->data; GList *next_item = g_list_next (item); - if (known_conflict->time < current_time - collision_timeout) { + if (known_conflict->time + collision_timeout < current_time) { gchar *buf; conflicting_addresses = g_list_delete_link (conflicting_addresses, item);