mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-11-22 17:51:16 +00:00
webrtcbin: Fix uint64 -> uint confusion for ice-candidate priority
ICE candidate priority is a 32-bit field and reported as such in the webrtcbin statistics, but the documentation was incorrect, and the unit test was looking for a uint64. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7338>
This commit is contained in:
parent
7da5d03b29
commit
97845475c5
2 changed files with 2 additions and 3 deletions
|
@ -9169,7 +9169,7 @@ gst_webrtc_bin_class_init (GstWebRTCBinClass * klass)
|
|||
* "address" G_TYPE_STRING address of the candidate, allowing for IPv4, IPv6 and FQDNs
|
||||
* "port" G_TYPE_UINT port number of the candidate
|
||||
* "candidate-type" G_TYPE_STRING RTCIceCandidateType
|
||||
* "priority" G_TYPE_UINT64 calculated as defined in RFC 5245
|
||||
* "priority" G_TYPE_UINT calculated as defined in RFC 5245
|
||||
* "protocol" G_TYPE_STRING Either "udp" or "tcp". Based on the "transport" defined in RFC 5245
|
||||
* "relay-protocol" G_TYPE_STRING protocol used by the endpoint to communicate with the TURN server. Only present for local candidates. Either "udp", "tcp" or "tls"
|
||||
* "url" G_TYPE_STRING URL of the ICE server from which the candidate was obtained. Only present for local candidates
|
||||
|
|
|
@ -1753,8 +1753,7 @@ validate_candidate_stats (const GstStructure * s, const GstStructure * stats)
|
|||
fail_unless (gst_structure_get (s, "port", G_TYPE_UINT, &port, NULL));
|
||||
fail_unless (gst_structure_get (s, "candidate-type", G_TYPE_STRING,
|
||||
&candidateType, NULL));
|
||||
fail_unless (gst_structure_get (s, "priority", G_TYPE_UINT64, &priority,
|
||||
NULL));
|
||||
fail_unless (gst_structure_get (s, "priority", G_TYPE_UINT, &priority, NULL));
|
||||
fail_unless (gst_structure_get (s, "protocol", G_TYPE_STRING, &protocol,
|
||||
NULL));
|
||||
|
||||
|
|
Loading…
Reference in a new issue