From 97845475c5a559acb375e10981756b877004f33f Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Fri, 16 Aug 2024 22:33:03 +1000 Subject: [PATCH] webrtcbin: Fix uint64 -> uint confusion for ice-candidate priority ICE candidate priority is a 32-bit field and reported as such in the webrtcbin statistics, but the documentation was incorrect, and the unit test was looking for a uint64. Part-of: --- subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c | 2 +- subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c index d72b067d3e..6b77394551 100644 --- a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c +++ b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c @@ -9169,7 +9169,7 @@ gst_webrtc_bin_class_init (GstWebRTCBinClass * klass) * "address" G_TYPE_STRING address of the candidate, allowing for IPv4, IPv6 and FQDNs * "port" G_TYPE_UINT port number of the candidate * "candidate-type" G_TYPE_STRING RTCIceCandidateType - * "priority" G_TYPE_UINT64 calculated as defined in RFC 5245 + * "priority" G_TYPE_UINT calculated as defined in RFC 5245 * "protocol" G_TYPE_STRING Either "udp" or "tcp". Based on the "transport" defined in RFC 5245 * "relay-protocol" G_TYPE_STRING protocol used by the endpoint to communicate with the TURN server. Only present for local candidates. Either "udp", "tcp" or "tls" * "url" G_TYPE_STRING URL of the ICE server from which the candidate was obtained. Only present for local candidates diff --git a/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c b/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c index 7007748fb2..47952e8f49 100644 --- a/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c +++ b/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c @@ -1753,8 +1753,7 @@ validate_candidate_stats (const GstStructure * s, const GstStructure * stats) fail_unless (gst_structure_get (s, "port", G_TYPE_UINT, &port, NULL)); fail_unless (gst_structure_get (s, "candidate-type", G_TYPE_STRING, &candidateType, NULL)); - fail_unless (gst_structure_get (s, "priority", G_TYPE_UINT64, &priority, - NULL)); + fail_unless (gst_structure_get (s, "priority", G_TYPE_UINT, &priority, NULL)); fail_unless (gst_structure_get (s, "protocol", G_TYPE_STRING, &protocol, NULL));