mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

visual: use unused value

Browse source 
ret is assigned but not used and in the next cycle of the loop it is overwritten
with default_prepare_output_buffer (). If there is a flow error the function
should return instead.

CID #1226475
This commit is contained in:
Luis de Bethencourt 2015-01-12 15:27:18 +00:00
parent 32e6220cfd
commit 7cc048f4df
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/libvisual/gstaudiovisualizer.c
View file

@ -1150,6 +1150,8 @@ gst_audio_visualizer_chain (GstPad * pad, GstObject * parent,
if (klass->render) { if (klass->render) {
if (!klass->render (scope, inbuf, &outframe)) { if (!klass->render (scope, inbuf, &outframe)) {
ret = GST_FLOW_ERROR; ret = GST_FLOW_ERROR;
gst_video_frame_unmap (&outframe);
goto beach;
} else { } else {
/* run various post processing (shading and geometric transformation) */ /* run various post processing (shading and geometric transformation) */
/* FIXME: SHADER assumes 32bpp */ /* FIXME: SHADER assumes 32bpp */