From 7cc048f4df3cd51b84a628021b9f8cf0a92045fe Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Mon, 12 Jan 2015 15:27:18 +0000 Subject: [PATCH] visual: use unused value ret is assigned but not used and in the next cycle of the loop it is overwritten with default_prepare_output_buffer (). If there is a flow error the function should return instead. CID #1226475 --- ext/libvisual/gstaudiovisualizer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ext/libvisual/gstaudiovisualizer.c b/ext/libvisual/gstaudiovisualizer.c index 3d5a39cade..639f1e4898 100644 --- a/ext/libvisual/gstaudiovisualizer.c +++ b/ext/libvisual/gstaudiovisualizer.c @@ -1150,6 +1150,8 @@ gst_audio_visualizer_chain (GstPad * pad, GstObject * parent, if (klass->render) { if (!klass->render (scope, inbuf, &outframe)) { ret = GST_FLOW_ERROR; + gst_video_frame_unmap (&outframe); + goto beach; } else { /* run various post processing (shading and geometric transformation) */ /* FIXME: SHADER assumes 32bpp */