webrtc: don't disallow transceiver direction changes

Initial testing seems to suggest that we support them reasonably well
(at least for BUNDLEd streams).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5045>
This commit is contained in:
Matthew Waters 2022-11-09 14:25:00 +11:00 committed by GStreamer Marge Bot
parent 13f4066580
commit 77e01571c8

View file

@ -5746,7 +5746,7 @@ _update_transceiver_from_sdp_media (GstWebRTCBin * webrtc,
"Cannot intersect dtls setup attributes for media %u", media_idx); "Cannot intersect dtls setup attributes for media %u", media_idx);
return; return;
} }
#if 0
if (prev_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_NONE if (prev_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_NONE
&& new_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_INACTIVE && new_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_INACTIVE
&& prev_dir != new_dir) { && prev_dir != new_dir) {
@ -5756,7 +5756,7 @@ _update_transceiver_from_sdp_media (GstWebRTCBin * webrtc,
media_idx); media_idx);
return; return;
} }
#endif
if (!bundled || bundle_idx == media_idx) { if (!bundled || bundle_idx == media_idx) {
new_rtcp_rsize = _media_has_attribute_key (local_media, "rtcp-rsize") new_rtcp_rsize = _media_has_attribute_key (local_media, "rtcp-rsize")
&& _media_has_attribute_key (remote_media, "rtcp-rsize"); && _media_has_attribute_key (remote_media, "rtcp-rsize");