From 77e01571c85ff4d1cdaa66984202a60fb2a767c3 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Wed, 9 Nov 2022 14:25:00 +1100 Subject: [PATCH] webrtc: don't disallow transceiver direction changes Initial testing seems to suggest that we support them reasonably well (at least for BUNDLEd streams). Part-of: --- subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c index a75951b0d6..020b7fdc48 100644 --- a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c +++ b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c @@ -5746,7 +5746,7 @@ _update_transceiver_from_sdp_media (GstWebRTCBin * webrtc, "Cannot intersect dtls setup attributes for media %u", media_idx); return; } - +#if 0 if (prev_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_NONE && new_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_INACTIVE && prev_dir != new_dir) { @@ -5756,7 +5756,7 @@ _update_transceiver_from_sdp_media (GstWebRTCBin * webrtc, media_idx); return; } - +#endif if (!bundled || bundle_idx == media_idx) { new_rtcp_rsize = _media_has_attribute_key (local_media, "rtcp-rsize") && _media_has_attribute_key (remote_media, "rtcp-rsize");