mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-20 21:16:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

libs: windows: wayland: fail if cannot remove last frame

Browse source 
Converity scan bug:

If the function returns an error value, the error value may be
mistaken for a normal value.

If g_atomic_pointer_compare_and_exchange() fails because the frame is
not the last one, the function fails. Thus, logging an info message.
This commit is contained in:
Víctor Manuel Jáquez Leal 2017-08-08 17:29:54 +02:00
parent fbffda4e2f
commit 775f912247
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
View file

@ -381,14 +381,16 @@ frame_done (FrameState * frame)
GST_VAAPI_WINDOW_WAYLAND_GET_PRIVATE (frame->window);
g_atomic_int_set (&frame->done, TRUE);
g_atomic_pointer_compare_and_exchange (&priv->last_frame, frame, NULL);
return g_atomic_int_dec_and_test (&priv->num_frames_pending);
if (g_atomic_pointer_compare_and_exchange (&priv->last_frame, frame, NULL))
return g_atomic_int_dec_and_test (&priv->num_frames_pending);
return FALSE;
}
static void
frame_done_callback (void *data, struct wl_callback *callback, uint32_t time)
{
frame_done (data);
if (!frame_done (data))
GST_INFO ("cannot remove last frame because it didn't match or empty");
}
static const struct wl_callback_listener frame_callback_listener = {
@ -401,7 +403,8 @@ frame_release_callback (void *data, struct wl_buffer *wl_buffer)
FrameState *const frame = data;
if (!frame->done)
frame_done (frame);
if (!frame_done (frame))
GST_INFO ("cannot remove last frame because it didn't match or empty");
wl_buffer_destroy (wl_buffer);
frame_state_free (frame);
}