mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-01 03:52:25 +00:00
Code Issues 1 Projects Releases Wiki Activity

libs: utils: glx: check return value

Browse source 
Coverity scan bug:

If the function returns an error value, the error value may be
mistaken for a normal value.

Function sscanf returns the number of assignations done. Validate this
return value with the number of expected variables to match.
This commit is contained in:
Víctor Manuel Jáquez Leal 2017-08-08 17:21:52 +02:00
parent d99d5704a4
commit fbffda4e2f
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gst-libs/gst/vaapi/gstvaapiutils_glx.c
View file

@ -1163,7 +1163,7 @@ GstVaapiGLApi
gl_get_current_api (guint * major, guint * minor)
{
const gchar *version;
gint maj, min, n;
gint maj, min, n, sret;
GstVaapiGLApi ret = (1 << 31);
while (ret != GST_VAAPI_GL_API_NONE) {
@ -1181,7 +1181,9 @@ gl_get_current_api (guint * major, guint * minor)
if (n < 13)
goto next;
sscanf (&version[10], "%d.%d", &maj, &min);
sret = sscanf (&version[10], "%d.%d", &maj, &min);
if (sret != 2)
goto next;
if (maj <= 0 || min < 0)
goto next;
@ -1196,7 +1198,9 @@ gl_get_current_api (guint * major, guint * minor)
goto next;
} else {
sscanf (version, "%d.%d", &maj, &min);
sret = sscanf (version, "%d.%d", &maj, &min);
if (sret != 2)
goto next;
if (maj <= 0 || min < 0)
goto next;