mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 04:01:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

player: Don't try to cache the GQuark for GST_PLAYER_ERROR

Browse source 
This is potentially racy (in the unlikely scenario that we get two
first-time calls to gst_player_error_quark() at the same time). This
should not impact anything in terms of performance since it's only on
the error path.

The call itself could just be inlined by making GST_PLAYER_ERROR be
defined to the g_quark_from_static_string() call, but this feels ugly
from an API perspective.
This commit is contained in:
Arun Raghavan 2016-12-08 11:22:38 +05:30 committed by Arun Raghavan
parent f149f6bc0e
commit 6a0d53b767
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst-libs/gst/player/gstplayer.c
View file

@ -70,12 +70,7 @@ GST_DEBUG_CATEGORY_STATIC (gst_player_debug);
GQuark GQuark
gst_player_error_quark (void) gst_player_error_quark (void)
{ {
static GQuark quark; return g_quark_from_static_string ("gst-player-error-quark");
if (!quark)
quark = g_quark_from_static_string ("gst-player-error-quark");
return quark;
} }
static GQuark QUARK_CONFIG; static GQuark QUARK_CONFIG;