From 6a0d53b767be43e937d530dc5b42beb2e71251ab Mon Sep 17 00:00:00 2001 From: Arun Raghavan Date: Thu, 8 Dec 2016 11:22:38 +0530 Subject: [PATCH] player: Don't try to cache the GQuark for GST_PLAYER_ERROR This is potentially racy (in the unlikely scenario that we get two first-time calls to gst_player_error_quark() at the same time). This should not impact anything in terms of performance since it's only on the error path. The call itself could just be inlined by making GST_PLAYER_ERROR be defined to the g_quark_from_static_string() call, but this feels ugly from an API perspective. --- gst-libs/gst/player/gstplayer.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/gst-libs/gst/player/gstplayer.c b/gst-libs/gst/player/gstplayer.c index f92f09e67d..cac55cb1ee 100644 --- a/gst-libs/gst/player/gstplayer.c +++ b/gst-libs/gst/player/gstplayer.c @@ -70,12 +70,7 @@ GST_DEBUG_CATEGORY_STATIC (gst_player_debug); GQuark gst_player_error_quark (void) { - static GQuark quark; - - if (!quark) - quark = g_quark_from_static_string ("gst-player-error-quark"); - - return quark; + return g_quark_from_static_string ("gst-player-error-quark"); } static GQuark QUARK_CONFIG;