mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-21 05:26:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

transcodebin: Avoid plugin converter if filter handles ANY caps

Browse source 
For example identity or clocksync or this kind of elements can be
used with any data flow and we should not enforce decoding to row in
that case.
This commit is contained in:
Thibault Saunier 2020-11-19 18:31:34 -03:00
parent 878a196080
commit 5ccaa595a9
1 changed files with 31 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
gst/transcode/gsttranscodebin.c
View file

@ -148,6 +148,26 @@ post_missing_plugin_error (GstElement * dec, const gchar * element_name)
} }
/* *INDENT-ON* */ /* *INDENT-ON* */
static gboolean
filter_handles_any (GstElement * filter)
{
GList *tmp;
for (tmp = gst_element_get_pad_template_list (filter); tmp; tmp = tmp->next) {
GstPadTemplate *tmpl = tmp->data;
GstCaps *caps = gst_pad_template_get_caps (tmpl);
if (!gst_caps_is_any (caps)) {
gst_caps_unref (caps);
return FALSE;
}
gst_caps_unref (caps);
}
return gst_element_get_pad_template_list (filter) != NULL;
}
static GstPad * static GstPad *
_insert_filter (GstTranscodeBin * self, GstPad * sinkpad, GstPad * pad, _insert_filter (GstTranscodeBin * self, GstPad * sinkpad, GstPad * pad,
GstCaps * caps) GstCaps * caps)
@ -163,14 +183,16 @@ _insert_filter (GstTranscodeBin * self, GstPad * sinkpad, GstPad * pad,
if (self->video_filter && g_str_has_prefix (media_type, "video")) { if (self->video_filter && g_str_has_prefix (media_type, "video")) {
audio = FALSE; audio = FALSE;
if (!g_strcmp0 (media_type, "video/x-raw")) if (!g_strcmp0 (media_type, "video/x-raw")
|| filter_handles_any (self->video_filter))
filter = self->video_filter; filter = self->video_filter;
else else
GST_ERROR_OBJECT (pad, "decodebin pad does not produce raw data (%" GST_ERROR_OBJECT (pad, "decodebin pad does not produce raw data (%"
GST_PTR_FORMAT "), cannot add video filter '%s'", caps, GST_PTR_FORMAT "), cannot add video filter '%s'", caps,
GST_ELEMENT_NAME (self->video_filter)); GST_ELEMENT_NAME (self->video_filter));
} else if (self->audio_filter && g_str_has_prefix (media_type, "audio")) { } else if (self->audio_filter && g_str_has_prefix (media_type, "audio")) {
if (!g_strcmp0 (media_type, "audio/x-raw")) if (!g_strcmp0 (media_type, "audio/x-raw")
|| filter_handles_any (self->audio_filter))
filter = self->audio_filter; filter = self->audio_filter;
else else
GST_ERROR_OBJECT (pad, "decodebin pad does not produce raw data (%" GST_ERROR_OBJECT (pad, "decodebin pad does not produce raw data (%"
@ -181,7 +203,8 @@ _insert_filter (GstTranscodeBin * self, GstPad * sinkpad, GstPad * pad,
if (!filter) if (!filter)
return pad; return pad;
if ((filter_parent = gst_object_get_parent (GST_OBJECT (filter)))) { filter_parent = gst_object_get_parent (GST_OBJECT (filter));
if (filter_parent != GST_OBJECT_CAST (self)) {
GST_WARNING_OBJECT (self, GST_WARNING_OBJECT (self,
"Filter already in use (inside %" GST_PTR_FORMAT ").", filter_parent); "Filter already in use (inside %" GST_PTR_FORMAT ").", filter_parent);
GST_FIXME_OBJECT (self, GST_FIXME_OBJECT (self,
@ -191,13 +214,16 @@ _insert_filter (GstTranscodeBin * self, GstPad * sinkpad, GstPad * pad,
return pad; return pad;
} }
gst_object_unref (filter_parent);
/* We are guaranteed filters only have 1 unique sinkpad and srcpad */ /* We are guaranteed filters only have 1 unique sinkpad and srcpad */
GST_OBJECT_LOCK (filter); GST_OBJECT_LOCK (filter);
filter_sink = filter->sinkpads->data; filter_sink = filter->sinkpads->data;
filter_src = filter->srcpads->data; filter_src = filter->srcpads->data;
GST_OBJECT_UNLOCK (filter); GST_OBJECT_UNLOCK (filter);
if (audio) if (filter_handles_any (filter))
convert = gst_element_factory_make ("identity", NULL);
else if (audio)
convert = gst_element_factory_make ("audioconvert", NULL); convert = gst_element_factory_make ("audioconvert", NULL);
else else
convert = gst_element_factory_make ("videoconvert", NULL); convert = gst_element_factory_make ("videoconvert", NULL);
@ -639,7 +665,7 @@ _setup_avoid_reencoding (GstTranscodeBin * self)
&& self->audio_filter) && self->audio_filter)
filter = self->audio_filter; filter = self->audio_filter;
if (!filter) { if (!filter || filter_handles_any (filter)) {
GST_DEBUG_OBJECT (self, GST_DEBUG_OBJECT (self,
"adding %" GST_PTR_FORMAT " as output caps to decodebin", encodecaps); "adding %" GST_PTR_FORMAT " as output caps to decodebin", encodecaps);
gst_caps_append (decodecaps, encodecaps); gst_caps_append (decodecaps, encodecaps);