transcodebin: Add filter as soon as it is set

Instead of waiting so that we can simply use a clocksync element as
filter, otherwise we won't know the pipeline is live as it won't
return NO_PREROLL as one would expect in that case.

Adding it right away shouldn't create any issue, both ways are fine.
This commit is contained in:
Thibault Saunier 2020-11-19 18:39:33 -03:00
parent 530f694366
commit 878a196080

View file

@ -211,7 +211,7 @@ _insert_filter (GstTranscodeBin * self, GstPad * sinkpad, GstPad * pad,
return pad;
}
gst_bin_add_many (GST_BIN (self), convert, gst_object_ref (filter), NULL);
gst_bin_add_many (GST_BIN (self), convert, NULL);
convert_sink = gst_element_get_static_pad (convert, "sink");
g_assert (convert_sink);
@ -836,6 +836,8 @@ _set_filter (GstTranscodeBin * self, GstElement * filter, GstElement ** mfilter)
goto bail_out;
}
GST_OBJECT_UNLOCK (filter);
gst_bin_add (GST_BIN (self), gst_object_ref (filter));
}
GST_OBJECT_LOCK (self);