ext/jack/gstjackaudiosink.c: Try t better name clients. properly handle return codes when re- establishing links.

Original commit message from CVS:
* ext/jack/gstjackaudiosink.c: (gst_jack_ring_buffer_open_device),
(gst_jack_ring_buffer_acquire):
Try t better name clients. properly handle return codes when re-
establishing links.
This commit is contained in:
Stefan Kost 2007-04-04 07:36:28 +00:00 committed by Tim-Philipp Müller
parent a70ffeed7c
commit 5b2d689774

View file

@ -396,12 +396,17 @@ gst_jack_ring_buffer_open_device (GstRingBuffer * buf)
{ {
GstJackAudioSink *sink; GstJackAudioSink *sink;
jack_status_t status = 0; jack_status_t status = 0;
const gchar *name;
sink = GST_JACK_AUDIO_SINK (GST_OBJECT_PARENT (buf)); sink = GST_JACK_AUDIO_SINK (GST_OBJECT_PARENT (buf));
GST_DEBUG_OBJECT (sink, "open"); GST_DEBUG_OBJECT (sink, "open");
sink->client = gst_jack_audio_client_new ("GStreamer", sink->server, name = g_get_application_name ();
if (!name)
name = "GStreamer";
sink->client = gst_jack_audio_client_new (name, sink->server,
GST_JACK_CLIENT_SINK, GST_JACK_CLIENT_SINK,
jack_shutdown_cb, jack_shutdown_cb,
jack_process_cb, jack_buffer_size_cb, jack_sample_rate_cb, buf, &status); jack_process_cb, jack_buffer_size_cb, jack_sample_rate_cb, buf, &status);
@ -526,9 +531,11 @@ gst_jack_ring_buffer_acquire (GstRingBuffer * buf, GstRingBufferSpec * spec)
("No more physical ports, leaving some ports unconnected")); ("No more physical ports, leaving some ports unconnected"));
break; break;
} }
GST_DEBUG_OBJECT (sink, "try connecting to %s",
jack_port_name (sink->ports[i]));
/* connect the port to a physical port */ /* connect the port to a physical port */
if ((res = jack_connect (client, jack_port_name (sink->ports[i]), res = jack_connect (client, jack_port_name (sink->ports[i]), ports[i]);
ports[i]))) if (res != 0 && res != EEXIST)
goto cannot_connect; goto cannot_connect;
} }
free (ports); free (ports);
@ -558,13 +565,14 @@ out_of_ports:
could_not_activate: could_not_activate:
{ {
GST_ELEMENT_ERROR (sink, RESOURCE, SETTINGS, (NULL), GST_ELEMENT_ERROR (sink, RESOURCE, SETTINGS, (NULL),
("Could not activate client (%d)", res)); ("Could not activate client (%d:%s)", res, g_strerror (res)));
return FALSE; return FALSE;
} }
cannot_connect: cannot_connect:
{ {
GST_ELEMENT_ERROR (sink, RESOURCE, SETTINGS, (NULL), GST_ELEMENT_ERROR (sink, RESOURCE, SETTINGS, (NULL),
("Could not connect output ports to physical ports (%d)", res)); ("Could not connect output ports to physical ports (%d:%s)",
res, g_strerror (res)));
free (ports); free (ports);
return FALSE; return FALSE;
} }