mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-25 07:26:29 +00:00
Code Issues 1 Projects Releases Wiki Activity

glmixer: Possible null pointer dereference

Browse source 
While printing error message when context fails, error variable is not being used anymore
so it will lead to null pointer dereference

https://bugzilla.gnome.org/show_bug.cgi?id=748287
This commit is contained in:
Vineeth T M 2015-04-22 18:54:45 +09:00 committed by Matthew Waters
parent 66a5cad6c1
commit 52a40dfc48
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/gl/gstglmixer.c
View file

@ -502,7 +502,6 @@ gst_gl_mixer_decide_allocation (GstGLBaseMixer * base_mix, GstQuery * query)
GstCaps *caps; GstCaps *caps;
guint min, max, size; guint min, max, size;
gboolean update_pool; gboolean update_pool;
GError *error = NULL;
guint out_width, out_height; guint out_width, out_height;
out_width = GST_VIDEO_INFO_WIDTH (&vagg->info); out_width = GST_VIDEO_INFO_WIDTH (&vagg->info);
@ -566,8 +565,7 @@ gst_gl_mixer_decide_allocation (GstGLBaseMixer * base_mix, GstQuery * query)
context_error: context_error:
{ {
GST_ELEMENT_ERROR (mix, RESOURCE, NOT_FOUND, ("%s", error->message), GST_ELEMENT_ERROR (mix, RESOURCE, NOT_FOUND, ("Context error"), (NULL));
(NULL));
return FALSE; return FALSE;
} }
} }