From 52a40dfc48f96a7fafe0da63823ef583b77e4b48 Mon Sep 17 00:00:00 2001 From: Vineeth T M Date: Wed, 22 Apr 2015 18:54:45 +0900 Subject: [PATCH] glmixer: Possible null pointer dereference While printing error message when context fails, error variable is not being used anymore so it will lead to null pointer dereference https://bugzilla.gnome.org/show_bug.cgi?id=748287 --- ext/gl/gstglmixer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ext/gl/gstglmixer.c b/ext/gl/gstglmixer.c index 96d6e2ac42..8e35af10b0 100644 --- a/ext/gl/gstglmixer.c +++ b/ext/gl/gstglmixer.c @@ -502,7 +502,6 @@ gst_gl_mixer_decide_allocation (GstGLBaseMixer * base_mix, GstQuery * query) GstCaps *caps; guint min, max, size; gboolean update_pool; - GError *error = NULL; guint out_width, out_height; out_width = GST_VIDEO_INFO_WIDTH (&vagg->info); @@ -566,8 +565,7 @@ gst_gl_mixer_decide_allocation (GstGLBaseMixer * base_mix, GstQuery * query) context_error: { - GST_ELEMENT_ERROR (mix, RESOURCE, NOT_FOUND, ("%s", error->message), - (NULL)); + GST_ELEMENT_ERROR (mix, RESOURCE, NOT_FOUND, ("Context error"), (NULL)); return FALSE; } }