mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-23 10:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

audioaggregator: Don't leak pads

Browse source 
all audioaggregator subclasses were leaking the first sink pad :)
This commit is contained in:
Edward Hervey 2017-12-20 15:02:30 +01:00 committed by Edward Hervey
parent 26cd1f108e
commit 12f8410cd2
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst-libs/gst/audio/gstaudioaggregator.c
View file

@ -743,7 +743,6 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad,
&& info.rate != downstream_rate) || (first_configured_pad && info.rate != downstream_rate) || (first_configured_pad
&& info.rate != first_configured_pad->info.rate)) { && info.rate != first_configured_pad->info.rate)) {
gst_pad_push_event (GST_PAD (aaggpad), gst_event_new_reconfigure ()); gst_pad_push_event (GST_PAD (aaggpad), gst_event_new_reconfigure ());
gst_object_unref (first_configured_pad);
ret = FALSE; ret = FALSE;
} else { } else {
GST_OBJECT_LOCK (aaggpad); GST_OBJECT_LOCK (aaggpad);
@ -755,6 +754,9 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad,
} }
done: done:
if (first_configured_pad)
gst_object_unref (first_configured_pad);
if (downstream_caps) if (downstream_caps)
gst_caps_unref (downstream_caps); gst_caps_unref (downstream_caps);