From 12f8410cd20eaa4e1da1674d20c0a5ac5fc37488 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Wed, 20 Dec 2017 15:02:30 +0100 Subject: [PATCH] audioaggregator: Don't leak pads all audioaggregator subclasses were leaking the first sink pad :) --- gst-libs/gst/audio/gstaudioaggregator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gst-libs/gst/audio/gstaudioaggregator.c b/gst-libs/gst/audio/gstaudioaggregator.c index 8772ae86fc..d749b9b7cf 100644 --- a/gst-libs/gst/audio/gstaudioaggregator.c +++ b/gst-libs/gst/audio/gstaudioaggregator.c @@ -743,7 +743,6 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad, && info.rate != downstream_rate) || (first_configured_pad && info.rate != first_configured_pad->info.rate)) { gst_pad_push_event (GST_PAD (aaggpad), gst_event_new_reconfigure ()); - gst_object_unref (first_configured_pad); ret = FALSE; } else { GST_OBJECT_LOCK (aaggpad); @@ -755,6 +754,9 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad, } done: + if (first_configured_pad) + gst_object_unref (first_configured_pad); + if (downstream_caps) gst_caps_unref (downstream_caps);