mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-23 10:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

interlace: Add FIXME comment about false passthrough bug

Browse source 
If interlace-mode is missing from upstream caps, we can falsely do
passthrough when in fact we'd have to switch fields.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>
This commit is contained in:
Vivia Nikolaidou 2020-06-18 20:41:35 +03:00
parent 7d6afed2bb
commit 0c63c8d1f5
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/interlace/gstinterlace.c
View file

@ -453,6 +453,13 @@ gst_interlace_setcaps (GstInterlace * interlace, GstCaps * caps)
}
if (gst_caps_can_intersect (caps, othercaps)) {
/* FIXME: field-order is optional in the caps. This means that, if we're
* in a non-telecine mode and we have TFF upstream and
* top-field-first=FALSE in interlace (or the other way around), AND
* field-order isn't mentioned in the caps, we will do passthrough here
* and end up outptuting wrong data. Must detect missing field-order info
* and not do passthrough in that case, but instead check the
* GstVideoBufferFlags at the switch_fields check */
interlace->passthrough = TRUE;
} else {
if (GST_VIDEO_INFO_IS_INTERLACED (&info)) {