From 0c63c8d1f543ff6c0801c71c6c11d5f9425560d1 Mon Sep 17 00:00:00 2001 From: Vivia Nikolaidou Date: Thu, 18 Jun 2020 20:41:35 +0300 Subject: [PATCH] interlace: Add FIXME comment about false passthrough bug If interlace-mode is missing from upstream caps, we can falsely do passthrough when in fact we'd have to switch fields. Part-of: --- gst/interlace/gstinterlace.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gst/interlace/gstinterlace.c b/gst/interlace/gstinterlace.c index a15de748da..31760ac12b 100644 --- a/gst/interlace/gstinterlace.c +++ b/gst/interlace/gstinterlace.c @@ -453,6 +453,13 @@ gst_interlace_setcaps (GstInterlace * interlace, GstCaps * caps) } if (gst_caps_can_intersect (caps, othercaps)) { + /* FIXME: field-order is optional in the caps. This means that, if we're + * in a non-telecine mode and we have TFF upstream and + * top-field-first=FALSE in interlace (or the other way around), AND + * field-order isn't mentioned in the caps, we will do passthrough here + * and end up outptuting wrong data. Must detect missing field-order info + * and not do passthrough in that case, but instead check the + * GstVideoBufferFlags at the switch_fields check */ interlace->passthrough = TRUE; } else { if (GST_VIDEO_INFO_IS_INTERLACED (&info)) {