mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-03 05:59:44 +00:00
Code Issues 1 Projects Releases Wiki Activity

jpegparse: turn some bus warnings into object ones

Browse source 
For some cameras `gst_jpeg_parse_app0()` fails on a invalid segment.
While this is likely a driver or firmware bug that should be addressed
accordingly, it's not fatal and likely does not deserve a bus message on
every frame, flooding journals.

Turn down the volume of the warnings by turning them into object
warnings. If we conclude that in some cases we'd still want bus
warnings, they can be done more fine-grained in the
`gst_jpeg_parse_appX()` functions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6490>
This commit is contained in:
Robert Mader 2024-03-30 15:57:36 +01:00 committed by GStreamer Marge Bot
parent 4b5a265571
commit 0a26a92b2b
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
subprojects/gst-plugins-bad/gst/jpegformat/gstjpegparse.c
View file

@ -937,22 +937,16 @@ gst_jpeg_parse_handle_frame (GstBaseParse * bparse, GstBaseParseFrame * frame,
GST_WARNING_OBJECT (parse, "Failed to parse com segment"); GST_WARNING_OBJECT (parse, "Failed to parse com segment");
break; break;
case GST_JPEG_MARKER_APP0: case GST_JPEG_MARKER_APP0:
if (!gst_jpeg_parse_app0 (parse, &seg)) { if (!gst_jpeg_parse_app0 (parse, &seg))
GST_ELEMENT_WARNING (parse, STREAM, FORMAT, GST_WARNING_OBJECT (parse, "Failed to parse app0 segment");
("Invalid data"), ("Failed to parse app0 segment"));
}
break; break;
case GST_JPEG_MARKER_APP1: case GST_JPEG_MARKER_APP1:
if (!gst_jpeg_parse_app1 (parse, &seg)) { if (!gst_jpeg_parse_app1 (parse, &seg))
GST_ELEMENT_WARNING (parse, STREAM, FORMAT, GST_WARNING_OBJECT (parse, "Failed to parse app1 segment");
("Invalid data"), ("Failed to parse app1 segment"));
}
break; break;
case GST_JPEG_MARKER_APP14: case GST_JPEG_MARKER_APP14:
if (!gst_jpeg_parse_app14 (parse, &seg)) { if (!gst_jpeg_parse_app14 (parse, &seg))
GST_ELEMENT_WARNING (parse, STREAM, FORMAT, GST_WARNING_OBJECT (parse, "Failed to parse app14 segment");
("Invalid data"), ("Failed to parse app14 segment"));
}
break; break;
case GST_JPEG_MARKER_DHT: case GST_JPEG_MARKER_DHT:
case GST_JPEG_MARKER_DAC: case GST_JPEG_MARKER_DAC: