From 0a26a92b2b88e6db2ef65be843952483f665ddb9 Mon Sep 17 00:00:00 2001 From: Robert Mader Date: Sat, 30 Mar 2024 15:57:36 +0100 Subject: [PATCH] jpegparse: turn some bus warnings into object ones For some cameras `gst_jpeg_parse_app0()` fails on a invalid segment. While this is likely a driver or firmware bug that should be addressed accordingly, it's not fatal and likely does not deserve a bus message on every frame, flooding journals. Turn down the volume of the warnings by turning them into object warnings. If we conclude that in some cases we'd still want bus warnings, they can be done more fine-grained in the `gst_jpeg_parse_appX()` functions. Part-of: --- .../gst/jpegformat/gstjpegparse.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst/jpegformat/gstjpegparse.c b/subprojects/gst-plugins-bad/gst/jpegformat/gstjpegparse.c index 9574613c1b..1dda8c5f1a 100644 --- a/subprojects/gst-plugins-bad/gst/jpegformat/gstjpegparse.c +++ b/subprojects/gst-plugins-bad/gst/jpegformat/gstjpegparse.c @@ -937,22 +937,16 @@ gst_jpeg_parse_handle_frame (GstBaseParse * bparse, GstBaseParseFrame * frame, GST_WARNING_OBJECT (parse, "Failed to parse com segment"); break; case GST_JPEG_MARKER_APP0: - if (!gst_jpeg_parse_app0 (parse, &seg)) { - GST_ELEMENT_WARNING (parse, STREAM, FORMAT, - ("Invalid data"), ("Failed to parse app0 segment")); - } + if (!gst_jpeg_parse_app0 (parse, &seg)) + GST_WARNING_OBJECT (parse, "Failed to parse app0 segment"); break; case GST_JPEG_MARKER_APP1: - if (!gst_jpeg_parse_app1 (parse, &seg)) { - GST_ELEMENT_WARNING (parse, STREAM, FORMAT, - ("Invalid data"), ("Failed to parse app1 segment")); - } + if (!gst_jpeg_parse_app1 (parse, &seg)) + GST_WARNING_OBJECT (parse, "Failed to parse app1 segment"); break; case GST_JPEG_MARKER_APP14: - if (!gst_jpeg_parse_app14 (parse, &seg)) { - GST_ELEMENT_WARNING (parse, STREAM, FORMAT, - ("Invalid data"), ("Failed to parse app14 segment")); - } + if (!gst_jpeg_parse_app14 (parse, &seg)) + GST_WARNING_OBJECT (parse, "Failed to parse app14 segment"); break; case GST_JPEG_MARKER_DHT: case GST_JPEG_MARKER_DAC: