mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-03 01:02:19 +00:00
Code Issues 1 Projects Releases Wiki Activity

glsyncmeta: don't glFinish() everytime a sync point is set

Browse source 
At minimum, we only need to glFlush() if we are in a shared GL context
environment.  Move the glFinish() to when the actual wait is requested
which may be never.  Improves the throughput on older GL systems without
GL3/GLES3 and/or fence sync objects.
This commit is contained in:
Matthew Waters 2016-10-21 13:10:47 +11:00 committed by Tim-Philipp Müller
parent 99f5ac40db
commit 08e20ff131
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gst-libs/gst/gl/gstglsyncmeta.c
View file

@ -53,16 +53,11 @@ _default_set_sync_gl (GstGLSyncMeta * sync_meta, GstGLContext * context)
}
sync_meta->data =
(gpointer) gl->FenceSync (GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
if (gst_gl_context_is_shared (context))
/* if we only have a single context, the wait will flush for us */
gl->Flush ();
GST_LOG ("setting sync object %p", sync_meta->data);
} else {
/* XXX: this a little over the top if the CPU is never going to
* access the data, however this is the legacy path, so... */
gl->Finish ();
}
if (gst_gl_context_is_shared (context))
gl->Flush ();
}
static void
@ -89,6 +84,8 @@ _default_wait_cpu_gl (GstGLSyncMeta * sync_meta, GstGLContext * context)
gl->ClientWaitSync ((GLsync) sync_meta->data,
GL_SYNC_FLUSH_COMMANDS_BIT, 1000000000 /* 1s */ );
} while (res == GL_TIMEOUT_EXPIRED);
} else {
gl->Finish ();
}
}