mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

d3d12videosink: Fix buffer leak

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5875>
This commit is contained in:
Seungha Yang 2024-01-02 21:03:49 +09:00 committed by GStreamer Marge Bot
parent b0ef890726
commit 087e39564d
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
subprojects/gst-plugins-bad/sys/d3d12/gstd3d12videosink.cpp
View file

@ -115,8 +115,6 @@ static void gst_d3d12_videosink_get_property (GObject * object, guint prop_id,
static void gst_d3d12_video_sink_finalize (GObject * object); static void gst_d3d12_video_sink_finalize (GObject * object);
static void gst_d3d12_video_sink_set_context (GstElement * element, static void gst_d3d12_video_sink_set_context (GstElement * element,
GstContext * context); GstContext * context);
static gboolean gst_d3d12_video_sink_set_caps (GstBaseSink * sink,
GstCaps * caps);
static gboolean gst_d3d12_video_sink_start (GstBaseSink * sink); static gboolean gst_d3d12_video_sink_start (GstBaseSink * sink);
static gboolean gst_d3d12_video_sink_stop (GstBaseSink * sink); static gboolean gst_d3d12_video_sink_stop (GstBaseSink * sink);
static gboolean gst_d3d12_video_sink_unlock (GstBaseSink * sink); static gboolean gst_d3d12_video_sink_unlock (GstBaseSink * sink);
@ -798,8 +796,6 @@ gst_d3d12_video_sink_prepare (GstBaseSink * sink, GstBuffer * buffer)
GstBuffer *upload = nullptr; GstBuffer *upload = nullptr;
auto mem = gst_buffer_peek_memory (buffer, 0); auto mem = gst_buffer_peek_memory (buffer, 0);
if (!gst_is_d3d12_memory (mem)) { if (!gst_is_d3d12_memory (mem)) {
GstBuffer *upload = nullptr;
gst_buffer_pool_acquire_buffer (priv->pool, &upload, nullptr); gst_buffer_pool_acquire_buffer (priv->pool, &upload, nullptr);
if (!upload) { if (!upload) {
GST_ERROR_OBJECT (self, "Couldn't allocate upload buffer"); GST_ERROR_OBJECT (self, "Couldn't allocate upload buffer");
@ -815,7 +811,7 @@ gst_d3d12_video_sink_prepare (GstBaseSink * sink, GstBuffer * buffer)
if (!gst_video_frame_map (&out_frame, &priv->info, upload, GST_MAP_WRITE)) { if (!gst_video_frame_map (&out_frame, &priv->info, upload, GST_MAP_WRITE)) {
GST_ERROR_OBJECT (self, "Couldn't map upload frame"); GST_ERROR_OBJECT (self, "Couldn't map upload frame");
gst_video_frame_unmap (&out_frame); gst_video_frame_unmap (&in_frame);
gst_buffer_unref (upload); gst_buffer_unref (upload);
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }