mirrors/gstreamer-rs
mirrors/gstreamer-rs
1
1
Fork 1
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer-rs.git synced 2024-12-23 16:40:35 +00:00
Code Issues Projects Releases Wiki Activity

gstreamer: Simplify element subclass panic catching functions

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1188>
This commit is contained in:
Sebastian Dröge 2023-01-14 16:27:13 +02:00
parent 37bfb78fdc
commit aa23ddbbdb
1 changed files with 6 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
gstreamer/src/subclass/element.rs
View file

@ -150,12 +150,7 @@ pub trait ElementImplExt: ObjectSubclass {
fn panicked(&self) -> &atomic::AtomicBool; fn panicked(&self) -> &atomic::AtomicBool;
fn catch_panic<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R, P: IsA<Element>>( fn catch_panic<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R>(&self, fallback: G, f: F) -> R;
&self,
element: &P,
fallback: G,
f: F,
) -> R;
fn catch_panic_pad_function<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R>( fn catch_panic_pad_function<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R>(
parent: Option<&crate::Object>, parent: Option<&crate::Object>,
@ -329,20 +324,8 @@ impl<T: ElementImpl> ElementImplExt for T {
.expect("instance not initialized correctly") .expect("instance not initialized correctly")
} }
fn catch_panic<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R, P: IsA<Element>>( fn catch_panic<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R>(&self, fallback: G, f: F) -> R {
&self, panic_to_error!(self, fallback(), { f(self) })
element: &P,
fallback: G,
f: F,
) -> R {
unsafe {
assert!(element.type_().is_a(T::type_()));
let ptr: *mut ffi::GstElement = element.as_ptr() as *mut _;
let instance = &*(ptr as *mut T::Instance);
let imp = instance.imp();
panic_to_error!(imp, fallback(), { f(imp) })
}
} }
fn catch_panic_pad_function<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R>( fn catch_panic_pad_function<R, F: FnOnce(&Self) -> R, G: FnOnce() -> R>(
@ -350,15 +333,10 @@ impl<T: ElementImpl> ElementImplExt for T {
fallback: G, fallback: G,
f: F, f: F,
) -> R { ) -> R {
unsafe { let element = parent.unwrap().dynamic_cast_ref::<Self::Type>().unwrap();
let wrap = parent.as_ref().unwrap().downcast_ref::<Element>().unwrap(); let imp = element.imp();
assert!(wrap.type_().is_a(Self::type_()));
let ptr: *mut ffi::GstElement = wrap.to_glib_none().0;
let instance = &*(ptr as *mut Self::Instance);
let imp = instance.imp();
panic_to_error!(imp, fallback(), { f(imp) }) panic_to_error!(imp, fallback(), { f(imp) })
}
} }
fn post_error_message(&self, msg: crate::ErrorMessage) { fn post_error_message(&self, msg: crate::ErrorMessage) {