mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer-rs.git
synced 2024-11-21 17:11:04 +00:00
gst: BufferList::foreach{_mut} discard bool result
If we really wanted to return a value, we would use `ControlFlow`. In Rust, if we need to inform the caller that processing has stopped, we'd rather do this by updating a variable from within the `func`. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1584>
This commit is contained in:
parent
33781c5e65
commit
3f969485b7
1 changed files with 6 additions and 6 deletions
|
@ -136,7 +136,7 @@ impl BufferListRef {
|
|||
}
|
||||
|
||||
#[doc(alias = "gst_buffer_list_foreach")]
|
||||
pub fn foreach<F: FnMut(&Buffer, usize) -> ControlFlow<(), ()>>(&self, func: F) -> bool {
|
||||
pub fn foreach<F: FnMut(&Buffer, usize) -> ControlFlow<(), ()>>(&self, func: F) {
|
||||
unsafe extern "C" fn trampoline<F: FnMut(&Buffer, usize) -> ControlFlow<(), ()>>(
|
||||
buffer: *mut *mut ffi::GstBuffer,
|
||||
idx: u32,
|
||||
|
@ -152,11 +152,11 @@ impl BufferListRef {
|
|||
let mut func = func;
|
||||
let func_ptr: &mut F = &mut func;
|
||||
|
||||
from_glib(ffi::gst_buffer_list_foreach(
|
||||
let _ = ffi::gst_buffer_list_foreach(
|
||||
self.as_ptr() as *mut _,
|
||||
Some(trampoline::<F>),
|
||||
func_ptr as *mut _ as *mut _,
|
||||
))
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -164,7 +164,7 @@ impl BufferListRef {
|
|||
pub fn foreach_mut<F: FnMut(Buffer, usize) -> ControlFlow<Option<Buffer>, Option<Buffer>>>(
|
||||
&mut self,
|
||||
func: F,
|
||||
) -> bool {
|
||||
) {
|
||||
unsafe extern "C" fn trampoline<
|
||||
F: FnMut(Buffer, usize) -> ControlFlow<Option<Buffer>, Option<Buffer>>,
|
||||
>(
|
||||
|
@ -202,11 +202,11 @@ impl BufferListRef {
|
|||
let mut func = func;
|
||||
let func_ptr: &mut F = &mut func;
|
||||
|
||||
from_glib(ffi::gst_buffer_list_foreach(
|
||||
let _ = ffi::gst_buffer_list_foreach(
|
||||
self.as_ptr() as *mut _,
|
||||
Some(trampoline::<F>),
|
||||
func_ptr as *mut _ as *mut _,
|
||||
))
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue