mirrors/gstreamer-rs
mirrors/gstreamer-rs
1
1
Fork 1
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer-rs.git synced 2025-01-22 15:08:12 +00:00
Code Issues Projects Releases Wiki Activity

gstreamer/element: Don't steal floating references passed into release_pad()

Browse source 
They are apparently not part of this element so we can directly return
here instead of stealing the reference.
This commit is contained in:
Sebastian Dröge 2019-12-07 22:58:26 +02:00
parent 802fa4fcb4
commit 2375c9da59
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gstreamer/src/subclass/element.rs
View file

@ -420,6 +420,12 @@ unsafe extern "C" fn element_release_pad<T: ObjectSubclass>(
let imp = instance.get_impl(); let imp = instance.get_impl();
let wrap: Element = from_glib_borrow(ptr); let wrap: Element = from_glib_borrow(ptr);
// If we get a floating reference passed simply return here. It can't be stored inside this
// element, and if we continued to use it we would take ownership of this floating reference.
if gobject_sys::g_object_is_floating(pad as *mut gobject_sys::GObject) != glib_sys::GFALSE {
return;
}
gst_panic_to_error!(&wrap, &instance.panicked(), (), { gst_panic_to_error!(&wrap, &instance.panicked(), (), {
imp.release_pad(&wrap, &from_glib_none(pad)) imp.release_pad(&wrap, &from_glib_none(pad))
}) })