DateTime: manual impl for PartialOrd, PartialEq and Debug

See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/217

Gir_Gst.toml

@@ -69,7 +69,6 @@ generate = [
     "Gst.ParseFlags",
     "Gst.TaskState",
     "Gst.PluginDependencyFlags",
-    "Gst.DateTime",
     "Gst.BufferPoolAcquireFlags",
     "Gst.PromiseResult",
 ]
@@ -1356,3 +1355,10 @@ must_use = true
 name = "Gst.ClockReturn"
 status = "generate"
 must_use = true
+
+[[object]]
+name = "Gst.DateTime"
+status = "generate"
+    [[object.derive]]
+    # Don't auto-implement traits
+    name = ""

gstreamer/src/auto/date_time.rs

@@ -8,7 +8,7 @@ use glib::GString;
 use gst_sys;
 
 glib_wrapper! {
-    #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
+    #[derive()]
     pub struct DateTime(Shared<gst_sys::GstDateTime>);
 
     match fn {

gstreamer/src/date_time.rs

@@ -6,9 +6,223 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+use std::cmp;
 use std::fmt;
+
 use DateTime;
 
+impl DateTime {
+    /// Get the [`DateTime`](struct.DateTime.html) in UTC
+    pub fn to_utc(&self) -> Option<DateTime> {
+        if !self.has_time() {
+            // No time => no TZ offset
+            return Some(self.clone());
+        }
+
+        assert!(self.has_year() && self.has_month() && self.has_day() && self.has_time());
+
+        // Can instantiate `gst::DateTime` without seconds using `gst::DateTime::new`
+        // with `-1f64` for the `second` argument
+        // however, the resulting instance can't be translated to `glib::DateTime`
+        if self.has_second() {
+            self.to_g_date_time()
+                .expect("DateTime::to_utc: to_g_date_time")
+                .to_utc()
+                .as_ref()
+                .and_then(DateTime::new_from_g_date_time)
+        } else {
+            // It would be cheaper to build a `glib::DateTime` direcly, unfortunetaly
+            // this would require using `glib::TimeZone::new_offset` which is feature-gated
+            // to `glib/v2_58`. So we need to build a new `gst::DateTime` with `0f64`
+            // and then discard seconds again
+            DateTime::new(
+                self.get_time_zone_offset(),
+                self.get_year(),
+                self.get_month(),
+                self.get_day(),
+                self.get_hour(),
+                self.get_minute(),
+                0f64,
+            )
+            .to_g_date_time()
+            .expect("DateTime::to_utc: to_g_date_time")
+            .to_utc()
+            .map(|g_date_time_utc| {
+                DateTime::new(
+                    0f32, // UTC TZ offset
+                    g_date_time_utc.get_year(),
+                    g_date_time_utc.get_month(),
+                    g_date_time_utc.get_day_of_month(),
+                    g_date_time_utc.get_hour(),
+                    g_date_time_utc.get_minute(),
+                    -1f64, // No second
+                )
+            })
+        }
+    }
+}
+
+impl cmp::PartialOrd for DateTime {
+    /// *NOTE 1:* When comparing a partially defined [`DateTime`](struct.DateTime.html) `d1`
+    /// such as *"2019/8/20"* with a [`DateTime`](struct.DateTime.html) with a time part `d2`
+    /// such as *"2019/8/20 21:10"*:
+    ///
+    /// - `d1` includes `d2`,
+    /// - neither `d1` < `d2` nor `d1` > `d2`,
+    /// - and `d1` != `d2`,
+    ///
+    /// so we can only return `None`.
+    ///
+    /// This is the reason why [`DateTime`](struct.DateTime.html) neither implements
+    /// [`Ord`](https://doc.rust-lang.org/nightly/std/cmp/trait.Ord.html)
+    /// nor [`Eq`](https://doc.rust-lang.org/nightly/std/cmp/trait.Eq.html).
+    ///
+    /// *NOTE 2:* When comparing a [`DateTime`](struct.DateTime.html) `d1` without a TZ offset
+    /// such as *"2019/8/20"* with a [`DateTime`](struct.DateTime.html) `d2` with a TZ offset
+    /// such as *"2019/8/20 21:10 +02:00"*, we can't tell in which TZ `d1` is expressed and which
+    /// time should be considered for an offset, therefore the two [`DateTime`s](struct.DateTime.html)
+    /// are compared in the same TZ.
+    fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> {
+        #[inline]
+        fn get_cmp(delta: i32) -> Option<cmp::Ordering> {
+            Some(if delta < 0 {
+                cmp::Ordering::Less
+            } else if delta == 0 {
+                cmp::Ordering::Equal
+            } else {
+                cmp::Ordering::Greater
+            })
+        }
+
+        if !(self.has_year() && other.has_year()) {
+            // Can't compare anything
+            return None;
+        }
+
+        // Normalize to UTC only if both members have time (see note 2).
+        let (self_norm, other_norm) = if self.has_time() && other.has_time() {
+            (self.to_utc()?, other.to_utc()?)
+        } else {
+            (self.clone(), other.clone())
+        };
+
+        let year_delta = self_norm.get_year() - other_norm.get_year();
+        if year_delta != 0 {
+            return get_cmp(year_delta);
+        }
+
+        // Same year
+
+        if !self.has_month() && !other.has_month() {
+            // Nothing left to compare
+            return get_cmp(year_delta);
+        }
+
+        if !(self.has_month() && other.has_month()) {
+            // One has month, the other doesn't => can't compare (note 1)
+            return None;
+        }
+
+        let month_delta = self_norm.get_month() - other_norm.get_month();
+        if month_delta != 0 {
+            return get_cmp(month_delta);
+        }
+
+        // Same year, same month
+
+        if !self.has_day() && !other.has_day() {
+            // Nothing left to compare
+            return Some(cmp::Ordering::Equal);
+        }
+
+        if !(self.has_day() && other.has_day()) {
+            // One has day, the other doesn't => can't compare (note 1)
+            return None;
+        }
+
+        let day_delta = self_norm.get_day() - other_norm.get_day();
+        if day_delta != 0 {
+            return get_cmp(day_delta);
+        }
+
+        // Same year, same month, same day
+
+        if !self.has_time() && !other.has_time() {
+            // Nothing left to compare
+            return Some(cmp::Ordering::Equal);
+        }
+
+        if !(self.has_time() && other.has_time()) {
+            // One has time, the other doesn't => can't compare (note 1)
+            return None;
+        }
+
+        let hour_delta = self_norm.get_hour() - other_norm.get_hour();
+        if hour_delta != 0 {
+            return get_cmp(hour_delta);
+        }
+
+        let minute_delta = self_norm.get_minute() - other_norm.get_minute();
+        if minute_delta != 0 {
+            return get_cmp(minute_delta);
+        }
+
+        // Same year, same month, same day, same time
+
+        if !self.has_second() && !other.has_second() {
+            // Nothing left to compare
+            return Some(cmp::Ordering::Equal);
+        }
+
+        if !(self.has_second() && other.has_second()) {
+            // One has second, the other doesn't => can't compare (note 1)
+            return None;
+        }
+        let second_delta = self_norm.get_second() - other_norm.get_second();
+        if second_delta != 0 {
+            return get_cmp(second_delta);
+        }
+
+        get_cmp(self_norm.get_microsecond() - other_norm.get_microsecond())
+    }
+}
+
+impl cmp::PartialEq for DateTime {
+    /// See the notes for the [`DateTime` `PartialOrd` trait](struct.DateTime.html#impl-PartialOrd%3CDateTime%3E)
+    fn eq(&self, other: &Self) -> bool {
+        self.partial_cmp(other)
+            .map_or_else(|| false, |cmp| cmp == cmp::Ordering::Equal)
+    }
+}
+
+impl fmt::Debug for DateTime {
+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+        let mut debug_struct = f.debug_struct("DateTime");
+        if self.has_year() {
+            debug_struct.field("year", &self.get_year());
+        }
+        if self.has_month() {
+            debug_struct.field("month", &self.get_month());
+        }
+        if self.has_day() {
+            debug_struct.field("day", &self.get_day());
+        }
+        if self.has_time() {
+            debug_struct.field("hour", &self.get_hour());
+            debug_struct.field("minute", &self.get_minute());
+
+            if self.has_second() {
+                debug_struct.field("second", &self.get_second());
+                debug_struct.field("microsecond", &self.get_microsecond());
+            }
+
+            debug_struct.field("tz_offset", &self.get_time_zone_offset());
+        }
+
+        debug_struct.finish()
+    }
+}
+
 impl fmt::Display for DateTime {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         f.write_str(
@@ -18,3 +232,198 @@ impl fmt::Display for DateTime {
         )
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_to_utc() {
+        ::init().unwrap();
+
+        // Hour offset
+        let utc_date_time = DateTime::new(2f32, 2019, 8, 20, 20, 9, 42.123_456f64)
+            .to_utc()
+            .unwrap();
+        assert_eq!(utc_date_time.get_year(), 2019);
+        assert_eq!(utc_date_time.get_month(), 8);
+        assert_eq!(utc_date_time.get_day(), 20);
+        assert_eq!(utc_date_time.get_hour(), 18);
+        assert_eq!(utc_date_time.get_minute(), 9);
+        assert_eq!(utc_date_time.get_second(), 42);
+        assert_eq!(utc_date_time.get_microsecond(), 123_456);
+
+        // Year, month, day and hour offset
+        let utc_date_time = DateTime::new(2f32, 2019, 1, 1, 0, 0, 42.123_456f64)
+            .to_utc()
+            .unwrap();
+        assert_eq!(utc_date_time.get_year(), 2018);
+        assert_eq!(utc_date_time.get_month(), 12);
+        assert_eq!(utc_date_time.get_day(), 31);
+        assert_eq!(utc_date_time.get_hour(), 22);
+        assert_eq!(utc_date_time.get_minute(), 0);
+        assert_eq!(utc_date_time.get_second(), 42);
+        assert_eq!(utc_date_time.get_microsecond(), 123_456);
+
+        // Date without an hour (which implies no TZ)
+        let utc_date_time = DateTime::new_ymd(2019, 1, 1).to_utc().unwrap();
+        assert_eq!(utc_date_time.get_year(), 2019);
+        assert_eq!(utc_date_time.get_month(), 1);
+        assert_eq!(utc_date_time.get_day(), 1);
+        assert!(!utc_date_time.has_time());
+        assert!(!utc_date_time.has_second());
+
+        // Date without seconds
+        let utc_date_time = DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64)
+            .to_utc()
+            .unwrap();
+        assert_eq!(utc_date_time.get_year(), 2018);
+        assert_eq!(utc_date_time.get_month(), 5);
+        assert_eq!(utc_date_time.get_day(), 28);
+        assert_eq!(utc_date_time.get_hour(), 14);
+        assert_eq!(utc_date_time.get_minute(), 6);
+        assert!(!utc_date_time.has_second());
+    }
+
+    #[test]
+    fn test_partial_ord() {
+        ::init().unwrap();
+
+        // Different years
+        assert!(
+            DateTime::new(2f32, 2020, 8, 20, 19, 43, 42.123_456f64)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+        );
+
+        // Different months (order intentionally reversed)
+        assert!(
+            DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+                < DateTime::new(2f32, 2019, 9, 19, 19, 43, 42.123_456f64)
+        );
+
+        // Different days
+        assert!(
+            DateTime::new(2f32, 2019, 8, 21, 19, 43, 42.123_456f64)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+        );
+
+        // Different hours
+        assert!(
+            DateTime::new(2f32, 2019, 8, 20, 19, 44, 42.123_456f64)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+        );
+
+        // Different minutes
+        assert!(
+            DateTime::new(2f32, 2019, 8, 20, 19, 43, 44.123_456f64)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+        );
+
+        // Different seconds
+        assert!(
+            DateTime::new(2f32, 2019, 8, 20, 19, 43, 43.123_456f64)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+        );
+
+        // Different micro-seconds
+        assert!(
+            DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_457f64)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+        );
+
+        // Different TZ offsets
+        assert!(
+            DateTime::new(1f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 42.123_456f64)
+        );
+
+        // TZ offset leading to year, month, day, hour offset
+        assert!(
+            DateTime::new(2f32, 2019, 1, 1, 0, 0, 0f64)
+                < DateTime::new(1f32, 2018, 12, 31, 23, 59, 0f64)
+        );
+
+        // Partially defined `DateTime`
+        assert!(DateTime::new_ymd(2020, 8, 20) > DateTime::new_ymd(2019, 8, 20));
+        assert!(DateTime::new_ymd(2019, 9, 20) > DateTime::new_ymd(2019, 8, 20));
+        assert!(DateTime::new_ymd(2019, 8, 21) > DateTime::new_ymd(2019, 8, 20));
+
+        assert!(DateTime::new_ym(2020, 8) > DateTime::new_ym(2019, 8));
+        assert!(DateTime::new_ym(2019, 9) > DateTime::new_ym(2019, 8));
+        assert!(DateTime::new_ym(2019, 9) > DateTime::new_ymd(2019, 8, 20));
+
+        assert!(DateTime::new_y(2020) > DateTime::new_y(2019));
+        assert!(DateTime::new_ym(2020, 1) > DateTime::new_y(2019));
+
+        assert!(
+            DateTime::new(2f32, 2019, 8, 20, 19, 43, 44.123_456f64)
+                < DateTime::new_ymd(2020, 8, 20)
+        );
+
+        assert!(
+            DateTime::new_ymd(2020, 8, 20)
+                > DateTime::new(2f32, 2019, 8, 20, 19, 43, 44.123_456f64)
+        );
+
+        // Comparison occurs on the same TZ when the `DateTime` doesn't have time (note 2)
+        assert!(DateTime::new_ymd(2020, 1, 1) > DateTime::new(-2f32, 2019, 12, 31, 23, 59, 0f64));
+
+        // In the following cases, the partially defined `DateTime` is a range WRT
+        // the fully defined `DateTime` and this range includes the fully defined `DateTime`,
+        // but we can't tell if it's before or after and they are not equal (note 1)
+        assert!(DateTime::new(2f32, 2019, 8, 20, 19, 43, 44.123_456f64)
+            .partial_cmp(&DateTime::new_ymd(2019, 8, 20))
+            .is_none());
+
+        assert!(DateTime::new_ymd(2019, 8, 20)
+            .partial_cmp(&DateTime::new(2f32, 2019, 8, 20, 19, 43, 44.123_456f64))
+            .is_none());
+
+        assert!(DateTime::new_ym(2019, 1)
+            .partial_cmp(&DateTime::new_y(2019))
+            .is_none());
+    }
+
+    #[test]
+    fn test_eq() {
+        ::init().unwrap();
+
+        assert_eq!(
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, 42.123_456f64),
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, 42.123_456f64)
+        );
+
+        assert_eq!(
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, 0f64),
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, 0f64)
+        );
+
+        assert_eq!(
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64),
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64)
+        );
+
+        assert_eq!(
+            DateTime::new_ymd(2018, 5, 28),
+            DateTime::new_ymd(2018, 5, 28)
+        );
+
+        // In the following cases, the partially defined `DateTime` is a range WRT
+        // the fully defined `DateTime` and this range includes the fully defined `DateTime`,
+        // but they are not equal (note 1)
+        assert_ne!(
+            DateTime::new_ymd(2018, 5, 28),
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64)
+        );
+
+        assert_ne!(
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64),
+            DateTime::new_ym(2018, 5)
+        );
+
+        assert_ne!(
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64),
+            DateTime::new_y(2018)
+        );
+    }
+}

gstreamer/src/date_time_serde.rs

@@ -205,62 +205,35 @@ mod tests {
     fn test_deserialize() {
         ::init().unwrap();
 
-        // FIXME: compare `DateTime`s instances
-        // See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/217
-
         let datetime_ron = "YMDhmsTz(2018, 5, 28, 16, 6, 42.123456, 2)";
         let datetime_de: DateTime = ron::de::from_str(datetime_ron).unwrap();
-        assert_eq!(datetime_de.get_time_zone_offset(), 2f32);
-        assert_eq!(datetime_de.get_year(), 2018);
-        assert_eq!(datetime_de.get_month(), 5);
-        assert_eq!(datetime_de.get_day(), 28);
-        assert_eq!(datetime_de.get_hour(), 16);
-        assert_eq!(datetime_de.get_minute(), 6);
-        assert_eq!(datetime_de.get_second(), 42);
-        assert_eq!(datetime_de.get_microsecond(), 123_456);
+        assert_eq!(
+            datetime_de,
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, 42.123_456f64)
+        );
 
         let datetime_json = r#"{"YMDhmsTz":[2018,5,28,16,6,42.123456,2.0]}"#;
         let datetime_de: DateTime = serde_json::from_str(datetime_json).unwrap();
-        assert_eq!(datetime_de.get_time_zone_offset(), 2f32);
-        assert_eq!(datetime_de.get_year(), 2018);
-        assert_eq!(datetime_de.get_month(), 5);
-        assert_eq!(datetime_de.get_day(), 28);
-        assert_eq!(datetime_de.get_hour(), 16);
-        assert_eq!(datetime_de.get_minute(), 6);
-        assert_eq!(datetime_de.get_second(), 42);
-        assert_eq!(datetime_de.get_microsecond(), 123_456);
+        assert_eq!(
+            datetime_de,
+            DateTime::new(2f32, 2018, 5, 28, 16, 6, 42.123_456f64)
+        );
 
         let datetime_ron = "YMDhmTz(2018, 5, 28, 16, 6, 2)";
         let datetime_de: DateTime = ron::de::from_str(datetime_ron).unwrap();
-        assert!(datetime_de.has_time());
-        assert!(!datetime_de.has_second());
-        assert_eq!(datetime_de.get_time_zone_offset(), 2f32);
-        assert_eq!(datetime_de.get_year(), 2018);
-        assert_eq!(datetime_de.get_month(), 5);
-        assert_eq!(datetime_de.get_day(), 28);
-        assert_eq!(datetime_de.get_hour(), 16);
-        assert_eq!(datetime_de.get_minute(), 6);
+        assert_eq!(datetime_de, DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64));
 
         let datetime_ron = "YMD(2018, 5, 28)";
         let datetime_de: DateTime = ron::de::from_str(datetime_ron).unwrap();
-        assert!(datetime_de.has_day());
-        assert!(!datetime_de.has_time());
-        assert_eq!(datetime_de.get_year(), 2018);
-        assert_eq!(datetime_de.get_month(), 5);
-        assert_eq!(datetime_de.get_day(), 28);
+        assert_eq!(datetime_de, DateTime::new_ymd(2018, 5, 28));
 
         let datetime_ron = "YM(2018, 5)";
         let datetime_de: DateTime = ron::de::from_str(datetime_ron).unwrap();
-        assert!(datetime_de.has_month());
-        assert!(!datetime_de.has_day());
-        assert_eq!(datetime_de.get_year(), 2018);
-        assert_eq!(datetime_de.get_month(), 5);
+        assert_eq!(datetime_de, DateTime::new_ym(2018, 5));
 
         let datetime_ron = "Y(2018)";
         let datetime_de: DateTime = ron::de::from_str(datetime_ron).unwrap();
-        assert!(datetime_de.has_year());
-        assert!(!datetime_de.has_month());
-        assert_eq!(datetime_de.get_year(), 2018);
+        assert_eq!(datetime_de, DateTime::new_y(2018));
     }
 
     #[test]
@@ -270,55 +243,26 @@ mod tests {
         let datetime = DateTime::new(2f32, 2018, 5, 28, 16, 6, 42.123_456f64);
         let datetime_ser = ron::ser::to_string(&datetime).unwrap();
         let datetime_de: DateTime = ron::de::from_str(datetime_ser.as_str()).unwrap();
-        assert_eq!(
-            datetime_de.get_time_zone_offset(),
-            datetime.get_time_zone_offset()
-        );
-        assert_eq!(datetime_de.get_year(), datetime.get_year());
-        assert_eq!(datetime_de.get_month(), datetime.get_month());
-        assert_eq!(datetime_de.get_day(), datetime.get_day());
-        assert_eq!(datetime_de.get_hour(), datetime.get_hour());
-        assert_eq!(datetime_de.get_minute(), datetime.get_minute());
-        assert_eq!(datetime_de.get_second(), datetime.get_second());
-        assert_eq!(datetime_de.get_microsecond(), datetime.get_microsecond());
+        assert_eq!(datetime_de, datetime);
 
         let datetime = DateTime::new(2f32, 2018, 5, 28, 16, 6, -1f64);
         let datetime_ser = ron::ser::to_string(&datetime).unwrap();
         let datetime_de: DateTime = ron::de::from_str(datetime_ser.as_str()).unwrap();
-        assert!(datetime_de.has_time());
-        assert!(!datetime_de.has_second());
-        assert_eq!(
-            datetime_de.get_time_zone_offset(),
-            datetime.get_time_zone_offset()
-        );
-        assert_eq!(datetime_de.get_year(), datetime.get_year());
-        assert_eq!(datetime_de.get_month(), datetime.get_month());
-        assert_eq!(datetime_de.get_day(), datetime.get_day());
-        assert_eq!(datetime_de.get_hour(), datetime.get_hour());
-        assert_eq!(datetime_de.get_minute(), datetime.get_minute());
+        assert_eq!(datetime_de, datetime);
 
         let datetime = DateTime::new_ymd(2018, 5, 28);
         let datetime_ser = ron::ser::to_string(&datetime).unwrap();
         let datetime_de: DateTime = ron::de::from_str(datetime_ser.as_str()).unwrap();
-        assert!(datetime_de.has_day());
-        assert!(!datetime_de.has_time());
-        assert_eq!(datetime_de.get_year(), datetime.get_year());
-        assert_eq!(datetime_de.get_month(), datetime.get_month());
-        assert_eq!(datetime_de.get_day(), datetime.get_day());
+        assert_eq!(datetime_de, datetime);
 
         let datetime = DateTime::new_ym(2018, 5);
         let datetime_ser = ron::ser::to_string(&datetime).unwrap();
         let datetime_de: DateTime = ron::de::from_str(datetime_ser.as_str()).unwrap();
-        assert!(datetime_de.has_month());
-        assert!(!datetime_de.has_day());
-        assert_eq!(datetime_de.get_year(), datetime.get_year());
-        assert_eq!(datetime_de.get_month(), datetime.get_month());
+        assert_eq!(datetime_de, datetime);
 
         let datetime = DateTime::new_y(2018);
         let datetime_ser = ron::ser::to_string(&datetime).unwrap();
         let datetime_de: DateTime = ron::de::from_str(datetime_ser.as_str()).unwrap();
-        assert!(datetime_de.has_year());
-        assert!(!datetime_de.has_month());
-        assert_eq!(datetime_de.get_year(), datetime.get_year());
+        assert_eq!(datetime_de, datetime);
     }
 }

gstreamer/src/tags_serde.rs

@@ -491,12 +491,10 @@ mod tests {
             tags.get_index::<Date>(0).unwrap().get().unwrap(),
             glib::Date::new_dmy(28, glib::DateMonth::May, 2018)
         );
-        // FIXME: compare `DateTime` instances
-        // See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/217
-        let datetime = tags.get_index::<DateTime>(0).unwrap().get().unwrap();
-        assert_eq!(datetime.get_year(), 2018);
-        assert_eq!(datetime.get_month(), 5);
-        assert_eq!(datetime.get_day(), 28);
+        assert_eq!(
+            tags.get_index::<DateTime>(0).unwrap().get().unwrap(),
+            ::DateTime::new_ymd(2018, 5, 28)
+        );
         let sample = tags.get_index::<Image>(0).unwrap().get().unwrap();
         let buffer = sample.get_buffer().unwrap();
         {
@@ -532,12 +530,10 @@ mod tests {
             tags.get_index::<Date>(0).unwrap().get().unwrap(),
             glib::Date::new_dmy(28, glib::DateMonth::May, 2018)
         );
-        // FIXME: compare `DateTime` instances
-        // See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/217
-        let datetime = tags.get_index::<DateTime>(0).unwrap().get().unwrap();
-        assert_eq!(datetime.get_year(), 2018);
-        assert_eq!(datetime.get_month(), 5);
-        assert_eq!(datetime.get_day(), 28);
+        assert_eq!(
+            tags.get_index::<DateTime>(0).unwrap().get().unwrap(),
+            ::DateTime::new_ymd(2018, 5, 28)
+        );
         let sample = tags.get_index::<Image>(0).unwrap().get().unwrap();
         let buffer = sample.get_buffer().unwrap();
         {
@@ -606,10 +602,10 @@ mod tests {
             tags_de.get_index::<Date>(0).unwrap().get(),
             tags.get_index::<Date>(0).unwrap().get(),
         );
-        let datetime = tags.get_index::<DateTime>(0).unwrap().get().unwrap();
-        assert_eq!(datetime.get_year(), 2018);
-        assert_eq!(datetime.get_month(), 5);
-        assert_eq!(datetime.get_day(), 28);
+        assert_eq!(
+            tags.get_index::<DateTime>(0).unwrap().get().unwrap(),
+            ::DateTime::new_ymd(2018, 5, 28)
+        );
         let sample = tags.get_index::<Image>(0).unwrap().get().unwrap();
         let buffer = sample.get_buffer().unwrap();
         {

gstreamer/src/value_serde.rs

@@ -645,9 +645,10 @@ mod tests {
 
         assert!(slice[2].get::<String>().expect("slice[2]").is_none());
 
-        // FIXME: compare `DateTime` instances
-        // See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/217
-        assert!(slice[3].get::<DateTime>().expect("slice[3]").is_some());
+        assert_eq!(
+            DateTime::new(2f32, 2019, 8, 19, 13, 34, 42f64),
+            slice[3].get::<DateTime>().expect("slice[3]").unwrap()
+        );
 
         assert!(slice[4].get::<DateTime>().expect("slice[4]").is_none());
     }
@@ -753,12 +754,10 @@ mod tests {
 
         assert!(slice[2].get::<String>().expect("slice[2]").is_none());
 
-        // FIXME: compare `DateTime` instances
-        // See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/217
-        assert!(slice_de[3]
-            .get::<DateTime>()
-            .expect("slice_de[3]")
-            .is_some());
+        assert_eq!(
+            slice_de[3].get::<DateTime>().expect("slice_de[3]").unwrap(),
+            slice[3].get::<DateTime>().expect("slice[3]").unwrap()
+        );
 
         assert!(slice[4].get::<DateTime>().expect("slice[4]").is_none());
     }