mirrors/gstreamer-rs
mirrors/gstreamer-rs
1
1
Fork 1
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer-rs.git synced 2024-11-26 19:41:09 +00:00
Code Issues Projects Releases Wiki Activity

Change Structure/StructureRef to_string() to the minimal required fix

Browse source 
And add a comment to why we need it. No other struct with a to_string()
function is affected.

https://github.com/sdroege/gstreamer-rs/issues/101
This commit is contained in:
Sebastian Dröge 2018-04-07 13:37:44 +03:00
parent ce9b98f338
commit 03055f4e84
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
gstreamer/src/structure.rs
View file

@ -121,15 +121,15 @@ impl Drop for Structure {
impl fmt::Debug for Structure { impl fmt::Debug for Structure {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_tuple("Structure") f.debug_tuple("Structure").field(&self.to_string()).finish()
.field(&self.as_ref().to_string())
.finish()
} }
} }
impl fmt::Display for Structure { impl fmt::Display for Structure {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.write_str(&self.as_ref().to_string()) // Need to make sure to not call ToString::to_string() here, which
// we have because of the Display impl. We need StructureRef::to_string()
f.write_str(&StructureRef::to_string(self.as_ref()))
} }
} }
@ -508,13 +508,13 @@ impl StructureRef {
impl fmt::Display for StructureRef { impl fmt::Display for StructureRef {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.write_str(&StructureRef::to_string(self)) f.write_str(&self.to_string())
} }
} }
impl fmt::Debug for StructureRef { impl fmt::Debug for StructureRef {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.write_str(&StructureRef::to_string(self)) f.write_str(&self.to_string())
} }
} }