gst-plugins-rs/net
Mathieu Duponchelle e64546598d webrtcsink: fix segment format mismatch with remote offer
webrtcsink was starting the negotiation process on Ready and concurrently
moving the consumer pipeline to Playing, but when answering the remote
description was set so fast that input streams were connected (and the time
format set on appsrc) before the state change to Paused had completed.

This meant gst_base_src_start was happening after that and setting the format
back to bytes, the time segment that was next coming in then caused:

basesrc gstbasesrc.c:4255:gst_base_src_push_segment:<video_0> segment format mismatched, ignore

And the consumer pipeline errored out.

The same issue existed in theory when webrtcsink was creating the offer,
but was much harder to trigger as it required that the remote answer
came in before the state change to Paused had completed.

This commit fixes the issue by simply waiting for the state to have
changed to Paused before negotiating.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1786>
2024-09-20 14:46:06 +03:00
..
aws aws/s3hlssink: Do not call abort before finishing uploads 2024-07-06 17:55:46 +01:00
hlssink3 Fix various new clippy 1.79 warnings 2024-06-18 10:01:13 +00:00
ndi Fix various new clippy 1.79 warnings 2024-06-18 10:01:13 +00:00
onvif onvifmetadatapay: Set output caps earlier 2024-09-20 03:24:29 +00:00
raptorq Fix various new clippy 1.79 warnings 2024-06-18 10:01:13 +00:00
reqwest Fix various new clippy 1.79 warnings 2024-06-18 10:01:13 +00:00
rtp rtp: av1pay: Derive Default trait for the state instead of manual implementation 2024-06-18 10:52:50 +00:00
rtsp Fix clippy warnings after upgrade to Rust 1.77 2024-04-08 15:15:26 +03:00
webrtc webrtcsink: fix segment format mismatch with remote offer 2024-09-20 14:46:06 +03:00
webrtchttp whepsrc: Fix incorrect default caps 2024-09-19 13:39:45 +02:00