mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-02-23 08:06:18 +00:00
Code Issues Projects Releases Wiki Activity
3479 commits 14 branches 106 tags 56 MiB
Commit graph

872 commits

Author SHA1 Message Date
Mathieu Duponchelle
4d75091e91 awstranscriber: post warning message with details when item is late 
When the latency is configured to a value that is too low, items will be
pushed out with an adjusted timestamp, thus affecting synchronization.

It can be useful for the application to receive details about those
adjustments.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1897>
 2024-10-29 11:36:07 +00:00
Sebastian Dröge
da634989d9 Update to quick-xml 0.37 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1893>
 2024-10-29 06:51:38 +00:00
Sebastian Dröge
d9664d77b0 mpegtslivesrc: Parse PAT/PMT and only handle PCRs from the first program 
This matches default behaviour of tsdemux and makes sure we're not
jumping between different PCRs if there are multiple.

At a later time, program selection could be implemented.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1894>
 2024-10-28 13:25:43 +00:00
Jerome Colle
05e3c4a5a3 rtpbasedepay2: fix reference timestamp meta duplicates 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1892>
 2024-10-28 12:05:54 +00:00
Sanchayan Maity
199995201c net/quinn: Specify crypto provider explicitly 
rustls allows the choice of ring or aws-lc-rs as the cryptographic
library implementation. This is enabled/selected via Cargo feature
flags. We have plugins directly or indirectly depending on rustls
like quinn, aws and spotify. In the presence of multiple plugins,
selecting different implementations as the default, rustls can
panic.

The safest way to avoid this is by using builder_with_provider
and selecting a provider explicitly.

See below issues for further discussion and clarifications.
https://github.com/rustls/rustls/issues/1877
https://github.com/seanmonstar/reqwest/pull/2225

While at it, also specify features explicitly for quinn and rustls.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1884>
 2024-10-28 11:10:03 +00:00
Sebastian Dröge
d10a7224e1 Update to quick-xml 0.36 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1885>
 2024-10-28 09:33:11 +02:00
Sebastian Dröge
07f7730632 aws: Allow a deprecated BehaviourVersion for now 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1873>
 2024-10-22 20:21:55 +00:00
Sebastian Dröge
347b5987bd Fix a couple of type hierarchy bugs 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1873>
 2024-10-22 20:21:55 +00:00
Sebastian Dröge
6c0bfd3ffc webrtc: Silence two new Rust 1.82 clippy warnings 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1874>
 2024-10-22 19:29:28 +00:00
Sanchayan Maity
9c640c8bc3 net/quinn: Fix panic due to unset default crypto provider 
Fix CI failure that we see after the upgrade of rustls from
0.23.13 to 0.23.15.

Related docs/PR
https://docs.rs/rustls/latest/rustls/crypto/struct.CryptoProvider.html#using-the-per-process-default-cryptoprovider
https://github.com/quinn-rs/quinn/pull/1882

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1866>
 2024-10-21 10:31:36 +00:00
Sebastian Dröge
e824ac31f4 reqwesthttpsrc: Allow a server error after a seek 
There might be a server error because a seek would immediately close the
old connection without allowing for clean shutdown.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/527

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1863>
 2024-10-18 17:48:42 +00:00
Mathieu Duponchelle
2790fb41b2 webrtcsink: fix session not in place errors 
The InPlace/Taken logic was introduced to avoid using an extra lock
around the session, but it places expectations that are not always
obvious to meet around when a session is expected to be taken or not.

Any code that expects to have access to the sessions at all times thus
needs either extra logic in the session wrapper, or to maintain the
state of the session outside of the session (eg mids).

This commit removes the logic, and wraps sessions in Arc<Mutex>>.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1859>
 2024-10-18 10:53:16 +00:00
Chris Bainbridge
f5b90ba261 custom-signaller: add missing manual-sdp-munging property 
All signallers must now implement this property

Fixes #611

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1858>
 2024-10-18 09:33:42 +00:00
Guillaume Desmottes
57234522ec webrtc: janus: add 'janus-state' property to the sink 
This property can be used by applications to track the state of the
signaller, especially to know when the stream is up.

Fix #510

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1849>
 2024-10-10 16:56:25 -04:00
Guillaume Desmottes
6cc9945d4e webrtc: janus: fix typo in doc 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1849>
 2024-10-10 16:43:23 -04:00
Mathieu Duponchelle
5958e342c7 webrtcsink: fix naming of error dot files for discovery pipelines 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1844>
 2024-10-03 16:45:42 +01:00
Guillaume Desmottes
87697609a2 webrtc: allow PAR change in webrtcsink input caps 
We are already allowing resolution changes which can lead to change in
pixel-aspect-ratio.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1833>
 2024-10-01 17:42:21 +01:00
Sebastian Dröge
cfdea1dc68 Fix new Rust 1.81 clippy warnings 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1827>
 2024-09-28 19:57:11 +03:00
Sebastian Dröge
7b4a2daed0 rtpav1depay: Add wait-for-keyframe and request-keyframe properties 
These behave the same as the properties in other depayloaders. Keyframe
detection is based on the N flag in the aggregation header.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/598

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1825>
 2024-09-28 10:51:05 +01:00
Mathieu Duponchelle
8eedd0ac6d webrtcsrc: ensure source pad has msid when added 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1812>
 2024-09-26 06:33:44 +00:00
Mathieu Duponchelle
41f75378df webrtcsrc: fix default msid property value 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1812>
 2024-09-26 06:33:44 +00:00
François Laignel
8f542f084c webrtcsink: fix RFC7273 attributes 
RFC7273 related attributes are set in the SDP offer by passing them via the
transceiver `codec-preferences` signal. These attributes are intended to be set
at the media level so they must be prefixed by `a-` in the `Caps` argument to
the signal. Otherwise they end up under `a=fmtp`.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1811>
 2024-09-25 11:25:51 +01:00
Mathieu Duponchelle
9331824479 webrtcsrc: expose MSID property on source pad 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1796>
 2024-09-21 00:27:57 +02:00
Jan Schmidt
41cc7ee30b onvifmetadatapay: Set output caps earlier 
As soon as input caps arrive, we can set output
caps. This means upstream can send gap events earlier,
before there is any actual metadata to send

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1788>
 2024-09-19 14:25:37 +02:00
Sebastian Dröge
034742e4af mpegtslivesrc: Make sure to use the object as context for all debug logs 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1770>
 2024-09-09 15:49:08 +01:00
Sebastian Dröge
1a7cf29b04 mpegtslivesrc: Check if old compared to new PCR clock estimation is too far off 
It the difference between the two estimations is more than 1s then
consider this a discontinuity too.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1770>
 2024-09-09 15:49:08 +01:00
Sebastian Dröge
0758470e68 mpegtslivesrc: Fix order of parameters passed to add_observation() 
The first one should be the internal time, i.e. the monotonic clock time
in our case, and the second one the external time.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1770>
 2024-09-09 15:49:08 +01:00
Sebastian Dröge
34f85f8d9f mpegtslivesrc: Scale monotonic time on PCR disconts to allow for continuous clock times 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1770>
 2024-09-09 15:49:08 +01:00
Sebastian Dröge
59324a3da5 mpegtslivesrc: Set DISCONT flag on buffers at PCR discontinuities 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1770>
 2024-09-09 15:49:08 +01:00
Arun Raghavan
b1ea6d2e65 webrtc: Fix whipclientsink name in README 
The element name was changed, but the documentation wasn't updated to
match.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1765>
 2024-09-04 13:48:06 +01:00
Sebastian Dröge
553f36cfdb hlssink3: Update to sprintf 0.2 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1757>
 2024-08-27 21:48:52 +03:00
Sanchayan Maity
988c58de43 whepsrc: Fix incorrect default caps 
add-transceiver needs application/x-rtp caps and not raw caps. We were
providing raw caps which is incorrect.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1756>
 2024-08-27 09:51:05 +01:00
Sanchayan Maity
11e5262adb hlssink3: Use fragment duration from splitmuxsink if available 
splitmuxsink now reports fragment offset and duration in the
splitmuxsink-fragment-closed message. Use this duration value
for the MediaSegment when available.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1750>
 2024-08-26 12:38:09 +00:00
Mathieu Duponchelle
6eac72d78c net/aws: fix sanity check in transcribe loop 
When we receive a new alternative we want to avoid iterating out of
bounds, but the comparison between the current index and the length of
the alternative should not log an error when partial_index == length, as
Vec::drain(length..) is valid, and it is completely valid for AWS to
send us a new alternative with as many items as we have already
dequeued.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1752>
 2024-08-26 11:52:10 +01:00
Mathieu Duponchelle
88a6b6d428 net/webrtc: Add missing npm command to README 
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/589

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1747>
 2024-08-23 10:30:18 +00:00
Mathieu Duponchelle
4559b6a9f9 webrtcsink: fix segment format mismatch with remote offer 
webrtcsink was starting the negotiation process on Ready and concurrently
moving the consumer pipeline to Playing, but when answering the remote
description was set so fast that input streams were connected (and the time
format set on appsrc) before the state change to Paused had completed.

This meant gst_base_src_start was happening after that and setting the format
back to bytes, the time segment that was next coming in then caused:

basesrc gstbasesrc.c:4255:gst_base_src_push_segment:<video_0> segment format mismatched, ignore

And the consumer pipeline errored out.

The same issue existed in theory when webrtcsink was creating the offer,
but was much harder to trigger as it required that the remote answer
came in before the state change to Paused had completed.

This commit fixes the issue by simply waiting for the state to have
changed to Paused before negotiating.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1738>
 2024-08-23 09:30:03 +00:00
Sebastian Dröge
85151a6e4f Fix various 1.80 clippy warnings 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1740>
 2024-08-23 08:59:20 +03:00
Jerome Colle
1abe0fd5fe webrtcsink: add nvv4l2av1enc support 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1743>
 2024-08-22 09:59:22 +00:00
Sebastian Dröge
b99aab06f8 ndisrc: Move timestamp handling from demuxer to source 
This allows putting correct timestamps on buffers coming out of the
source already instead of leaving them unset until the demuxer.

And also calculate timestamps for metadata buffers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1726>
 2024-08-17 01:17:47 +01:00
Sebastian Dröge
71cd06e975 mpegtslivesrc: Handle PCR discontinuities as errors for now 
More work is needed to make this work seemlessly and right now it would
simply cause invalid timestamps to be created.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1722>
 2024-08-14 18:30:06 +01:00
Sebastian Dröge
2e2af95e2d hlssink3: Don't use is-live=true 
This sometimes produces imperfect timestamps that cause the fragment
duration to be slightly different than expected.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1719>
 2024-08-14 14:02:06 +01:00
Dave Lucia
a3d6308579 net/webrtc: Fix turn-servers nick: user -> use 
Noticed this typo

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1713>
 2024-08-14 09:34:59 +00:00
Sebastian Dröge
b673de4e07 webrtcsrc: Make sure to always call end_session() without the state lock 
This was already done in another place for the same reason: preventing a
deadlock. It's probably not correct as hinted by the FIXME comment but
better than deadlocking at least.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1715>
 2024-08-14 08:17:48 +00:00
Mathieu Duponchelle
c87ddd43e4 webrtcsink: fix assertions when finalizing 
Dumping the pipeline on state changes from an async bus handler was
triggering criticals.

Instead, dump from the sync handler.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1714>
 2024-08-13 18:07:13 +01:00
Sebastian Dröge
19cb695ce0 rtp: mp4gpay: Don't set seqnum-base on the caps 
This is supposed to be set by another layer, e.g. rtspsrc.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1705>
 2024-08-10 11:46:04 +01:00
Sebastian Dröge
bc81e78873 rtp: basepay: Fix off-by-one with seqnum-offset 
Setting a seqnum-offset of 1 would've caused the first packet to have a
seqnum of 2 instead of 1.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1705>
 2024-08-10 11:46:04 +01:00
Sebastian Dröge
489021ed55 rtp: basepay: Don't negotiate twice in the beginning 
If srcpad caps are already set as part of sinkpad caps handling, unset
the reconfigure flag so negotiation does not happen yet another time on
the first buffer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1705>
 2024-08-10 11:46:03 +01:00
Sebastian Dröge
76f21f3b50 rtp: basepay: Negotiate SSRC and PT with downstream if not set via property 
This makes the new payloaders closer to the old ones, and makes usage in
webrtcbin easier.

Also properly configure default PT of subclasses. Previously any PT that
was set for these subclasses via g_object_new() would be overridden by
the default one during construction.

Additionally, do SSRC collision handling while queueing output packets.
This is the more natural place as that's where the SSRC is actually
used, it happens potentially earlier and also allows to drain any
pending packets before the SSRC change in the caps.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/557

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1705>
 2024-08-10 11:46:03 +01:00
Sebastian Dröge
2d2aab3f3c rtp: basepay: Initialize class fields 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1705>
 2024-08-10 11:46:03 +01:00
Sebastian Dröge
3cce3f18c1 rtp: basepay: Don't unset stats on FlushStop 
They are still valid and unsetting them here would cause no stats to
ever be updated again until the next state change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1705>
 2024-08-10 11:46:03 +01:00