mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-11-26 05:21:00 +00:00
Code Issues Projects Releases Wiki Activity

fallbacksrc: Use new proxy_pad_chain_function() support when building pads

Browse source 
Less unsafe code.
This commit is contained in:
Sebastian Dröge 2020-06-23 10:01:27 +03:00
parent fc20df294e
commit fe274ac6e7
1 changed files with 12 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
utils/fallbackswitch/src/fallbacksrc.rs
View file

@ -781,15 +781,9 @@ impl FallbackSrc {
.get_pad_template(if is_audio { "audio" } else { "video" })
.unwrap();
let ghostpad = gst::GhostPad::builder_with_template(&templ, Some(&templ.get_name()))
.build_with_target(&srcpad)
.unwrap();
let proxypad = ghostpad.get_internal().expect("no internal pad");
.proxy_pad_chain_function({
let element_weak = element.downgrade();
// Safety: Nothing else can have a reference to the proxy pad yet apart from the ghost pad
// itself, so changing the chain function is still safe.
unsafe {
proxypad.set_chain_function(move |pad, _parent, buffer| {
move |pad, _parent, buffer| {
let element = match element_weak.upgrade() {
None => return Err(gst::FlowError::Flushing),
Some(element) => element,
@ -797,8 +791,10 @@ impl FallbackSrc {
let src = FallbackSrc::from_instance(&element);
src.proxy_pad_chain(&element, pad, buffer)
});
}
})
.build_with_target(&srcpad)
.unwrap();
element.add_pad(&ghostpad).unwrap();