mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-09-02 17:53:48 +00:00
Code Issues Projects Releases Wiki Activity

webrtcsink: fix deadlock on error setting remote description

Browse source 
Avoids another attempt to lock the sesion mutex recursively.
Take a copy of the session id string to be passed to the signaller and
drop the session mutex after removal of session from the hashmap

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2331>
This commit is contained in:
Taruntej Kanakamalla 2025-07-01 13:33:59 +05:30
parent f835e075ea
commit fc0b433e29
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/webrtc/src/webrtcsink/imp.rs
View file

@ -3767,12 +3767,14 @@ impl BaseWebRTCSink {
if remove {
let _ = state.sessions.remove(&session.id);
let session_id = session.id.clone();
drop(session);
state.finalize_session(&self.obj(), Session(session_clone.clone()));
drop(state_guard);
let settings = self.settings.lock().unwrap();
let signaller = settings.signaller.clone();
drop(settings);
signaller.end_session(&session.id);
signaller.end_session(&session_id);
}
}