mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-01-29 20:38:16 +00:00
Code Issues Projects Releases Wiki Activity

Implemente clippy suggestions

Browse source
This commit is contained in:
Raphael Dürscheid 2022-04-22 18:53:52 +02:00 committed by Sebastian Dröge
parent b66db922d8
commit ee200326ef
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
plugins/src/webrtcsink/imp.rs
View file

@ -271,7 +271,7 @@ impl Default for State {
fn make_converter_for_video_caps(caps: &gst::Caps) -> Result<gst::Element, Error> { fn make_converter_for_video_caps(caps: &gst::Caps) -> Result<gst::Element, Error> {
assert!(caps.is_fixed()); assert!(caps.is_fixed());
for feature in caps.features(0) { if let Some(feature) = caps.features(0) {
if feature.contains(CUDA_MEMORY_FEATURE) { if feature.contains(CUDA_MEMORY_FEATURE) {
return Ok(gst::parse_bin_from_description( return Ok(gst::parse_bin_from_description(
"cudaupload ! cudaconvert ! cudascale ! videorate drop-only=true skip-to-first=true", "cudaupload ! cudaconvert ! cudascale ! videorate drop-only=true skip-to-first=true",
@ -1393,7 +1393,7 @@ impl WebRTCSink {
.webrtcbin .webrtcbin
.emit_by_name::<()>("set-local-description", &[&offer, &None::<gst::Promise>]); .emit_by_name::<()>("set-local-description", &[&offer, &None::<gst::Promise>]);
if let Err(err) = state.signaller.handle_sdp(element, &peer_id, &offer) { if let Err(err) = state.signaller.handle_sdp(element, peer_id, &offer) {
gst_warning!( gst_warning!(
CAT, CAT,
"Failed to handle SDP for consumer {}: {}", "Failed to handle SDP for consumer {}: {}",
@ -1401,7 +1401,7 @@ impl WebRTCSink {
err err
); );
state.remove_consumer(element, &peer_id, true); state.remove_consumer(element, peer_id, true);
} }
} }
} }
@ -1734,7 +1734,7 @@ impl WebRTCSink {
})?; })?;
if settings.enable_data_channel_navigation { if settings.enable_data_channel_navigation {
state.navigation_handler = Some(NavigationEventHandler::new(&element, &webrtcbin)); state.navigation_handler = Some(NavigationEventHandler::new(element, &webrtcbin));
} }
state.consumers.insert(peer_id.to_string(), consumer); state.consumers.insert(peer_id.to_string(), consumer);
@ -1755,7 +1755,7 @@ impl WebRTCSink {
// //
// This is completely safe, as we know that by now all conditions are gathered: // This is completely safe, as we know that by now all conditions are gathered:
// webrtcbin is in the Ready state, and all its transceivers have codec_preferences. // webrtcbin is in the Ready state, and all its transceivers have codec_preferences.
self.negotiate(&element, peer_id); self.negotiate(element, peer_id);
pipeline.set_state(gst::State::Playing).map_err(|err| { pipeline.set_state(gst::State::Playing).map_err(|err| {
WebRTCSinkError::ConsumerPipelineError { WebRTCSinkError::ConsumerPipelineError {
@ -2004,8 +2004,7 @@ impl WebRTCSink {
} else { } else {
make_element("audiotestsrc", None)? make_element("audiotestsrc", None)?
}; };
let mut elements = Vec::new(); let mut elements = vec![src.clone()];
elements.push(src.clone());
if codec.is_video { if codec.is_video {
elements.push(make_converter_for_video_caps(caps)?); elements.push(make_converter_for_video_caps(caps)?);
@ -2018,7 +2017,7 @@ impl WebRTCSink {
gst::Element::link_many(elements_slice) gst::Element::link_many(elements_slice)
.with_context(|| format!("Running discovery pipeline for caps {}", caps))?; .with_context(|| format!("Running discovery pipeline for caps {}", caps))?;
let (_, _, pay) = setup_encoding(&pipe.0, &capsfilter, &caps, codec, None, true)?; let (_, _, pay) = setup_encoding(&pipe.0, &capsfilter, caps, codec, None, true)?;
let sink = make_element("fakesink", None)?; let sink = make_element("fakesink", None)?;
@ -2042,7 +2041,7 @@ impl WebRTCSink {
gst::MessageView::Error(err) => { gst::MessageView::Error(err) => {
pipe.0.debug_to_dot_file_with_ts( pipe.0.debug_to_dot_file_with_ts(
gst::DebugGraphDetails::all(), gst::DebugGraphDetails::all(),
format!("webrtcsink-discovery-error"), "webrtcsink-discovery-error".to_string(),
); );
return Err(err.error().into()); return Err(err.error().into());
} }
@ -2051,7 +2050,7 @@ impl WebRTCSink {
pipe.0.debug_to_dot_file_with_ts( pipe.0.debug_to_dot_file_with_ts(
gst::DebugGraphDetails::all(), gst::DebugGraphDetails::all(),
format!("webrtcsink-discovery-done"), "webrtcsink-discovery-done".to_string(),
); );
if let Some(s) = caps.structure(0) { if let Some(s) = caps.structure(0) {