mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-03-28 03:25:28 +00:00
Code Issues Projects Releases Wiki Activity

webrtcsink: Ignore more fields in caps change

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1838>
This commit is contained in:
Xavier Claessens 2024-11-25 14:31:04 -05:00
parent 362216f40b
commit e5f3ab4053
1 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
net/webrtc/src/webrtcsink/imp.rs
View file

@ -12,6 +12,7 @@ use gst_plugin_webrtc_signalling::server::{Server, ServerError};
use gst_rtp::prelude::*;
use gst_utils::StreamProducer;
use gst_video::subclass::prelude::*;
use gst_video::VideoMultiviewMode;
use gst_webrtc::{WebRTCDataChannel, WebRTCICETransportPolicy};
use tokio::io::AsyncReadExt;
use tokio::net::TcpListener;
@ -4085,11 +4086,30 @@ impl BaseWebRTCSink {
// a renegotiation.
let caps_type = current.name();
if caps_type.starts_with("video/") {
const VIDEO_ALLOWED_CHANGES: &[&str] =
&["width", "height", "framerate", "pixel-aspect-ratio"];
const VIDEO_ALLOWED_CHANGES: &[&str] = &[
"width",
"height",
"framerate",
"pixel-aspect-ratio",
"colorimetry",
"chroma-site",
];
current.remove_fields(VIDEO_ALLOWED_CHANGES.iter().copied());
new.remove_fields(VIDEO_ALLOWED_CHANGES.iter().copied());
// Multiview can be part of SDP, but missing field should be treated the same as mono view.
fn remove_multiview(s: &mut gst::Structure) {
let is_mono = match s.get::<VideoMultiviewMode>("multiview-mode") {
Ok(mode) => mode == VideoMultiviewMode::Mono,
Err(_) => true,
};
if is_mono {
s.remove_fields(["multiview-mode", "multiview-flags"])
}
}
remove_multiview(&mut current);
remove_multiview(&mut new);
} else if caps_type.starts_with("audio/") {
// TODO
}