cdgparse: mark palette commands as HEADER

Fix rendering with decodebin3 which is dropping the first input buffers
until it find a header or key frame.
This commit is contained in:
Guillaume Desmottes 2019-11-03 16:54:54 +01:00
parent 1ae57967ae
commit e5244fc36a

View file

@ -23,6 +23,8 @@ use crate::constants::{
};
const CDG_CMD_MEMORY_PRESET: u8 = 1;
const CDG_CMD_MEMORY_LOAD_COLOR_TABLE_1: u8 = 30;
const CDG_CMD_MEMORY_LOAD_COLOR_TABLE_2: u8 = 31;
struct CdgParse;
@ -173,7 +175,7 @@ impl BaseParseImpl for CdgParse {
return Ok((gst::FlowSuccess::Ok, skip));
}
let keyframe = {
let (keyframe, header) = {
let map = input.map_readable().ok_or_else(|| {
gst_element_error!(
element,
@ -184,8 +186,15 @@ impl BaseParseImpl for CdgParse {
})?;
let data = map.as_slice();
match data[1] & CDG_MASK {
// consider memory preset as keyframe as it clears the screen
data[1] & CDG_MASK == CDG_CMD_MEMORY_PRESET
CDG_CMD_MEMORY_PRESET => (true, false),
// mark palette commands as headers
CDG_CMD_MEMORY_LOAD_COLOR_TABLE_1 | CDG_CMD_MEMORY_LOAD_COLOR_TABLE_2 => {
(false, true)
}
_ => (false, false),
}
};
let pts = bytes_to_time(Bytes(Some(frame.get_offset())));
@ -195,6 +204,9 @@ impl BaseParseImpl for CdgParse {
if !keyframe {
buffer.set_flags(gst::BufferFlags::DELTA_UNIT);
}
if header {
buffer.set_flags(gst::BufferFlags::HEADER);
}
gst_debug!(CAT, obj: element, "Found frame pts={}", pts);