rtpgccbwe: Rename variable t to amplified_estimate

We normally multiply `self.estimate` with `MAX_DELTAS` (60).
Rename the variables that holds the result of this
calculation to `amplified_estimate` to make the distinction
clearer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1566>
This commit is contained in:
Martin Nordholts 2024-05-02 16:49:18 +02:00 committed by Thibault Saunier
parent 49d3dd17a2
commit d9aa0731f4

View file

@ -571,20 +571,20 @@ impl Detector {
return (NetworkUsage::Normal, self.estimate); return (NetworkUsage::Normal, self.estimate);
} }
let t = Duration::nanoseconds( let amplified_estimate = Duration::nanoseconds(
self.estimate.whole_nanoseconds() as i64 * i64::min(self.num_deltas, MAX_DELTAS), self.estimate.whole_nanoseconds() as i64 * i64::min(self.num_deltas, MAX_DELTAS),
); );
let usage = if t > self.threshold { let usage = if amplified_estimate > self.threshold {
NetworkUsage::Over NetworkUsage::Over
} else if t.whole_nanoseconds() < -self.threshold.whole_nanoseconds() { } else if amplified_estimate.whole_nanoseconds() < -self.threshold.whole_nanoseconds() {
NetworkUsage::Under NetworkUsage::Under
} else { } else {
NetworkUsage::Normal NetworkUsage::Normal
}; };
self.update_threshold(&t); self.update_threshold(&amplified_estimate);
(usage, t) (usage, amplified_estimate)
} }
fn update_threshold(&mut self, estimate: &Duration) { fn update_threshold(&mut self, estimate: &Duration) {
@ -620,7 +620,7 @@ impl Detector {
} }
fn overuse_filter(&mut self) { fn overuse_filter(&mut self) {
let (th_usage, estimate) = self.compare_threshold(); let (th_usage, amplified_estimate) = self.compare_threshold();
let now = Instant::now(); let now = Instant::now();
let delta = now - self.last_use_detector_update; let delta = now - self.last_use_detector_update;
@ -632,7 +632,7 @@ impl Detector {
if self.increasing_duration > OVERUSE_TIME_TH if self.increasing_duration > OVERUSE_TIME_TH
&& self.increasing_counter > 1 && self.increasing_counter > 1
&& estimate > self.last_overuse_estimate && amplified_estimate > self.last_overuse_estimate
{ {
self.usage = NetworkUsage::Over; self.usage = NetworkUsage::Over;
} }
@ -649,12 +649,12 @@ impl Detector {
"{:?} - self.estimate {} - estimate: {} - th: {} - inc_dur: {} - inc_cnt: {}", "{:?} - self.estimate {} - estimate: {} - th: {} - inc_dur: {} - inc_cnt: {}",
th_usage, th_usage,
self.estimate, self.estimate,
estimate, amplified_estimate,
self.threshold, self.threshold,
self.increasing_duration, self.increasing_duration,
self.increasing_counter, self.increasing_counter,
); );
self.last_overuse_estimate = estimate; self.last_overuse_estimate = amplified_estimate;
} }
} }