mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-12-24 11:00:29 +00:00
Code Issues Projects Releases Wiki Activity

gcc: Fix deadlock on shutdown

Browse source 
We were holding the element .state lock while trying to shutdown leading
to a deadlock.

Fixes: https://github.com/centricular/webrtcsink/issues/90
This commit is contained in:
Thibault Saunier 2022-08-31 09:03:41 -04:00 committed by Mathieu Duponchelle
parent 8605df4b16
commit c3a1536849
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/src/gcc/imp.rs
View file

@ -1120,6 +1120,8 @@ impl BandwidthEstimator {
} else { } else {
let mut state = self.state.lock().unwrap(); let mut state = self.state.lock().unwrap();
state.flow_return = Err(gst::FlowError::Flushing); state.flow_return = Err(gst::FlowError::Flushing);
drop(state);
self.srcpad.stop_task()?; self.srcpad.stop_task()?;
} }