file plugin: starting an already started element is a bug

... in the base class.

See discussion in:

https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/merge_requests/73
This commit is contained in:
François Laignel 2019-01-21 21:03:13 +01:00 committed by Sebastian Dröge
parent 45ebb4c629
commit b8d19920a8
2 changed files with 2 additions and 12 deletions

View file

@ -202,12 +202,7 @@ impl BaseSinkImpl for FileSink {
fn start(&self, element: &gst_base::BaseSink) -> bool {
let mut state = self.state.lock().unwrap();
if let State::Started { .. } = *state {
gst_element_info!(
element,
gst::CoreError::StateChange,
["FileSink already started"]
);
return false;
unreachable!("FileSink already started");
}
let settings = self.settings.lock().unwrap();

View file

@ -236,12 +236,7 @@ impl BaseSrcImpl for FileSrc {
fn start(&self, element: &gst_base::BaseSrc) -> bool {
let mut state = self.state.lock().unwrap();
if let State::Started { .. } = *state {
gst_element_info!(
element,
gst::CoreError::StateChange,
["FileSrc already started"]
);
return false;
unreachable!("FileSrc already started");
}
let settings = self.settings.lock().unwrap();