Add BaseTransform::transform_ip_passthrough()

This is called with an immutable BufferRef if we're running in
passthrough mode and the element was configured to pass passthrough
buffers to transform_ip.

Previously we would've gotten a mutable reference, that then would fail
all mutable operations.
This commit is contained in:
Sebastian Dröge 2018-01-15 10:34:00 +02:00
parent f81fbfd0b0
commit b3afb61bbc

View file

@ -101,6 +101,10 @@ pub trait BaseTransformImpl<T: BaseTransformBase>
fn transform_ip(&self, _element: &T, _buf: &mut gst::BufferRef) -> gst::FlowReturn { fn transform_ip(&self, _element: &T, _buf: &mut gst::BufferRef) -> gst::FlowReturn {
unimplemented!(); unimplemented!();
} }
fn transform_ip_passthrough(&self, _element: &T, _buf: &gst::BufferRef) -> gst::FlowReturn {
unimplemented!();
}
} }
any_impl!(BaseTransformBase, BaseTransformImpl); any_impl!(BaseTransformBase, BaseTransformImpl);
@ -389,6 +393,11 @@ macro_rules! box_base_transform_impl(
let imp: &$name<T> = self.as_ref(); let imp: &$name<T> = self.as_ref();
imp.transform_ip(element, buf) imp.transform_ip(element, buf)
} }
fn transform_ip_passthrough(&self, element: &T, buf: &gst::BufferRef) -> gst::FlowReturn {
let imp: &$name<T> = self.as_ref();
imp.transform_ip_passthrough(element, buf)
}
} }
}; };
); );
@ -700,6 +709,10 @@ where
let buf = buf as *mut gst_ffi::GstBuffer; let buf = buf as *mut gst_ffi::GstBuffer;
panic_to_error!(&wrap, &element.panicked, gst::FlowReturn::Error, { panic_to_error!(&wrap, &element.panicked, gst::FlowReturn::Error, {
imp.transform_ip(&wrap, gst::BufferRef::from_mut_ptr(buf)) if from_glib(gst_base_ffi::gst_base_transform_is_passthrough(ptr)) {
imp.transform_ip_passthrough(&wrap, gst::BufferRef::from_ptr(buf))
} else {
imp.transform_ip(&wrap, gst::BufferRef::from_mut_ptr(buf))
}
}).to_glib() }).to_glib()
} }