mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-02-16 21:05:15 +00:00
Code Issues Projects Releases Wiki Activity

Never fail downwards state changes

Browse source 
This causes bugs in GStreamer and leads to crashes and deadlocks
This commit is contained in:
Sebastian Dröge 2017-12-04 21:45:03 +02:00
parent 083371866a
commit ac09ae7d73
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
gst-plugin/src/element.rs
View file

@ -243,8 +243,18 @@ where
let wrap: T = from_glib_borrow(ptr as *mut InstanceStruct<T>);
let imp = &*element.imp;
panic_to_error!(&wrap, &element.panicked, gst::StateChangeReturn::Failure, {
imp.change_state(&wrap, from_glib(transition))
// *Never* fail downwards state changes, this causes bugs in GStreamer
// and leads to crashes and deadlocks.
let transition = from_glib(transition);
let fallback = match transition {
gst::StateChange::PlayingToPaused
| gst::StateChange::PausedToReady
| gst::StateChange::ReadyToNull => gst::StateChangeReturn::Success,
_ => gst::StateChangeReturn::Failure,
};
panic_to_error!(&wrap, &element.panicked, fallback, {
imp.change_state(&wrap, transition)
}).to_glib()
}