mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-09-02 17:53:48 +00:00
Code Issues Projects Releases Wiki Activity

ts: rt/pad: fix obsolete FIXMEs

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2278>
This commit is contained in:
François Laignel 2025-06-04 16:49:34 +02:00 committed by GStreamer Marge Bot
parent e3c97941ec
commit 9b677234dd
1 changed files with 7 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
generic/threadshare/src/runtime/pad.rs
View file

@ -118,8 +118,7 @@ fn event_to_event_full_serialized(
/// [`PadSrc`]: struct.PadSrc.html
/// [`pad` module]: index.html
pub trait PadSrcHandler: Clone + Send + Sync + 'static {
// FIXME we should use a GAT here: ObjectSubclass<Type: IsA<gst::Element> + Send>
type ElementImpl: ElementImpl + ObjectSubclass;
type ElementImpl: ElementImpl<Type: Send>;
fn src_activate(
self,
@ -159,15 +158,7 @@ pub trait PadSrcHandler: Clone + Send + Sync + 'static {
fn src_event(self, pad: &gst::Pad, imp: &Self::ElementImpl, event: gst::Event) -> bool {
gst::log!(RUNTIME_CAT, obj = pad, "Handling {:?}", event);
let elem = imp.obj();
// FIXME with GAT on `Self::ElementImpl`, we should be able to
// use `.upcast::<gst::Element>()`
//
// Safety: `Self::ElementImpl` is bound to `gst::subclass::ElementImpl`.
let element = unsafe { elem.unsafe_cast_ref::<gst::Element>() };
gst::Pad::event_default(pad, Some(element), event)
gst::Pad::event_default(pad, Some(imp.obj().as_ref()), event)
}
fn src_event_full(
@ -190,15 +181,7 @@ pub trait PadSrcHandler: Clone + Send + Sync + 'static {
false
} else {
gst::log!(RUNTIME_CAT, obj = pad, "Handling {:?}", query);
let elem = imp.obj();
// FIXME with GAT on `Self::ElementImpl`, we should be able to
// use `.upcast::<gst::Element>()`
//
// Safety: `Self::ElementImpl` is bound to `gst::subclass::ElementImpl`.
let element = unsafe { elem.unsafe_cast_ref::<gst::Element>() };
gst::Pad::query_default(pad, Some(element), query)
gst::Pad::query_default(pad, Some(imp.obj().as_ref()), query)
}
}
}
@ -512,8 +495,7 @@ impl Deref for PadSrc {
/// [`PadSink`]: struct.PadSink.html
/// [`pad` module]: index.html
pub trait PadSinkHandler: Clone + Send + Sync + 'static {
// FIXME we should use a GAT here: ObjectSubclass<Type: IsA<gst::Element> + Send>
type ElementImpl: ElementImpl + ObjectSubclass;
type ElementImpl: ElementImpl<Type: Send>;
fn sink_activate(
self,
@ -572,15 +554,7 @@ pub trait PadSinkHandler: Clone + Send + Sync + 'static {
fn sink_event(self, pad: &gst::Pad, imp: &Self::ElementImpl, event: gst::Event) -> bool {
assert!(!event.is_serialized());
gst::log!(RUNTIME_CAT, obj = pad, "Handling {:?}", event);
let elem = imp.obj();
// FIXME with GAT on `Self::ElementImpl`, we should be able to
// use `.upcast::<gst::Element>()`
//
// Safety: `Self::ElementImpl` is bound to `gst::subclass::ElementImpl`.
let element = unsafe { elem.unsafe_cast_ref::<gst::Element>() };
gst::Pad::event_default(pad, Some(element), event)
gst::Pad::event_default(pad, Some(imp.obj().as_ref()), event)
}
fn sink_event_serialized(
@ -590,16 +564,10 @@ pub trait PadSinkHandler: Clone + Send + Sync + 'static {
event: gst::Event,
) -> BoxFuture<'static, bool> {
assert!(event.is_serialized());
// FIXME with GAT on `Self::ElementImpl`, we should be able to
// use `.upcast::<gst::Element>()`
//
// Safety: `Self::ElementImpl` is bound to `gst::subclass::ElementImpl`.
let element = unsafe { elem.unsafe_cast::<gst::Element>() };
async move {
gst::log!(RUNTIME_CAT, obj = pad, "Handling {:?}", event);
gst::Pad::event_default(&pad, Some(&element), event)
gst::Pad::event_default(&pad, Some(&elem), event)
}
.boxed()
}
@ -646,15 +614,7 @@ pub trait PadSinkHandler: Clone + Send + Sync + 'static {
false
} else {
gst::log!(RUNTIME_CAT, obj = pad, "Handling {:?}", query);
let elem = imp.obj();
// FIXME with GAT on `Self::ElementImpl`, we should be able to
// use `.upcast::<gst::Element>()`
//
// Safety: `Self::ElementImpl` is bound to `gst::subclass::ElementImpl`.
let element = unsafe { elem.unsafe_cast_ref::<gst::Element>() };
gst::Pad::query_default(pad, Some(element), query)
gst::Pad::query_default(pad, Some(imp.obj().as_ref()), query)
}
}
}