mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-05-28 21:28:41 +00:00
Code Issues Projects Releases Wiki Activity

awss3sink: Add properties to set content-Type and content-disposition.

Browse source 
for uploaded object default content-type is set to binary/octet-stream,
which is correct.
metadata cannot be used to set content-type and content-disposition as
setting metadata add a prefix x-amz-meta to key
e.g. setting metadate "content-type=video/mp4" actually set value as
x-amz-meta-content-type. So these has to be seaprate property.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1085>
This commit is contained in:
rajneeshksoni 2023-02-09 17:44:16 +04:00 committed by Arun Raghavan
parent 4d9b6c5472
commit 994c79569e
2 changed files with 48 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
docs/plugins/gst_plugins_cache.json
View file

@ -257,6 +257,30 @@
"type": "gint64",
"writable": true
},
"content-disposition": {
"blurb": "Content-Disposition header to set for uploaded object",
"conditionally-available": false,
"construct": false,
"construct-only": false,
"controllable": false,
"default": "NULL",
"mutable": "null",
"readable": true,
"type": "gchararray",
"writable": true
},
"content-type": {
"blurb": "Content-Type header to set for uploaded object",
"conditionally-available": false,
"construct": false,
"construct-only": false,
"controllable": false,
"default": "NULL",
"mutable": "null",
"readable": true,
"type": "gchararray",
"writable": true
},
"endpoint-uri": {
"blurb": "The S3 endpoint URI to use",
"conditionally-available": false,

24
net/aws/src/s3sink/imp.rs
View file

@ -101,6 +101,7 @@ struct Settings {
bucket: Option<String>,
key: Option<String>,
content_type: Option<String>,
content_disposition: Option<String>,
buffer_size: u64,
access_key: Option<String>,
secret_access_key: Option<String>,
@ -153,6 +154,7 @@ impl Default for Settings {
bucket: None,
key: None,
content_type: None,
content_disposition: None,
access_key: None,
secret_access_key: None,
session_token: None,
@ -350,6 +352,7 @@ impl S3Sink {
let bucket = Some(url.bucket.clone());
let key = Some(url.object.clone());
let content_type = settings.content_type.clone();
let content_disposition = settings.content_disposition.clone();
let metadata = settings.to_metadata(self);
client
@ -357,6 +360,7 @@ impl S3Sink {
.set_bucket(bucket)
.set_key(key)
.set_content_type(content_type)
.set_content_disposition(content_disposition)
.set_metadata(metadata)
}
@ -753,6 +757,14 @@ impl ObjectImpl for S3Sink {
.nick("S3 endpoint URI")
.blurb("The S3 endpoint URI to use")
.build(),
glib::ParamSpecString::builder("content-type")
.nick("content-type")
.blurb("Content-Type header to set for uploaded object")
.build(),
glib::ParamSpecString::builder("content-disposition")
.nick("content-disposition")
.blurb("Content-Disposition header to set for uploaded object")
.build(),
]
});
@ -856,6 +868,16 @@ impl ObjectImpl for S3Sink {
let _ = self.set_uri(Some(&settings.to_uri()));
}
}
"content-type" => {
settings.content_type = value
.get::<Option<String>>()
.expect("type checked upstream");
}
"content-disposition" => {
settings.content_disposition = value
.get::<Option<String>>()
.expect("type checked upstream");
}
_ => unimplemented!(),
}
}
@ -895,6 +917,8 @@ impl ObjectImpl for S3Sink {
(settings.retry_attempts as i64 * request_timeout).to_value()
}
"endpoint-uri" => settings.endpoint_uri.to_value(),
"content-type" => settings.content_type.to_value(),
"content-disposition" => settings.content_disposition.to_value(),
_ => unimplemented!(),
}
}