mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-09-27 22:32:30 +00:00
Code Issues Projects Releases Wiki Activity

fallbacksrc: Disconnect signals on ReadyToNull

Browse source 
Otherwise multiple signal handlers will be connected to the source
This commit is contained in:
Seungha Yang 2022-02-25 22:50:52 +09:00 committed by Sebastian Dröge
parent 29006999a4
commit 88262e596d
1 changed files with 25 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
utils/fallbackswitch/src/fallbacksrc/custom_source/imp.rs
View file

@ -7,6 +7,7 @@
// SPDX-License-Identifier: MPL-2.0
use gst::glib;
use gst::glib::SignalHandlerId;
use gst::prelude::*;
use gst::subclass::prelude::*;
use gst::{gst_debug, gst_error};
@ -36,6 +37,9 @@ struct State {
pads: Vec<Stream>,
num_audio: usize,
num_video: usize,
pad_added_sig_id: Option<SignalHandlerId>,
pad_removed_sig_id: Option<SignalHandlerId>,
no_more_pads_sig_id: Option<SignalHandlerId>,
}
#[derive(Default)]
@ -203,7 +207,7 @@ impl CustomSource {
gst_debug!(CAT, obj: element, "Found sometimes pads");
let element_weak = element.downgrade();
source.connect_pad_added(move |_, pad| {
let pad_added_sig_id = source.connect_pad_added(move |_, pad| {
let element = match element_weak.upgrade() {
None => return,
Some(element) => element,
@ -215,7 +219,7 @@ impl CustomSource {
}
});
let element_weak = element.downgrade();
source.connect_pad_removed(move |_, pad| {
let pad_removed_sig_id = source.connect_pad_removed(move |_, pad| {
let element = match element_weak.upgrade() {
None => return,
Some(element) => element,
@ -226,7 +230,7 @@ impl CustomSource {
});
let element_weak = element.downgrade();
source.connect_no_more_pads(move |_| {
let no_more_pads_sig_id = source.connect_no_more_pads(move |_| {
let element = match element_weak.upgrade() {
None => return,
Some(element) => element,
@ -235,6 +239,11 @@ impl CustomSource {
src.handle_source_no_more_pads(&element);
});
let mut state = self.state.lock().unwrap();
state.pad_added_sig_id = Some(pad_added_sig_id);
state.pad_removed_sig_id = Some(pad_removed_sig_id);
state.no_more_pads_sig_id = Some(no_more_pads_sig_id);
}
Ok(gst::StateChangeSuccess::Success)
@ -361,6 +370,19 @@ impl CustomSource {
gst_debug!(CAT, obj: element, "Stopping");
let mut state = self.state.lock().unwrap();
let source = self.source.get().unwrap();
if let Some(id) = state.pad_added_sig_id.take() {
source.disconnect(id)
}
if let Some(id) = state.pad_removed_sig_id.take() {
source.disconnect(id)
}
if let Some(id) = state.no_more_pads_sig_id.take() {
source.disconnect(id)
}
let pads = mem::take(&mut state.pads);
state.num_audio = 0;
state.num_video = 0;